ci: Update and build on PR #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonIT
force-pushed
the
ci-PR-build
branch
7 times, most recently
from
3b72157
to
2f17c78
Compare
|
Finally it's working🎉 |
MrStahlfelge
requested changes
Nov 19, 2023
.github/workflows/pushaction.yml
Outdated
| branches: | ||
| - master | ||
| - sdl/** | ||
| on: [push, pull_request] |
There was a problem hiding this comment.
This will deploy a snapshot on each PR, very dangerous :)
There was a problem hiding this comment.
That's why I added the if: github.event_name == 'push' && github.ref == 'refs/heads/master' && github.repository_owner == 'libgdx' to the actual publish step ;)
There was a problem hiding this comment.
Ah, great. Can you add a comment so the next one won't stumble accross this?
MrStahlfelge
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still the issue with
linux-libc-dev:i386. I will look into that