Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange crashes on Google Developer Console #111

Closed
centy opened this issue Jul 21, 2016 · 9 comments
Closed

Strange crashes on Google Developer Console #111

centy opened this issue Jul 21, 2016 · 9 comments

Comments

@centy
Copy link

centy commented Jul 21, 2016

I am receiving some strange crashes.

java.lang.SecurityException: Requires READ_PHONE_STATE: Neither user 10098 nor current process has android.permission.READ_PHONE_STATE.
at android.os.Parcel.readException(Parcel.java:1546)
at android.os.Parcel.readException(Parcel.java:1499)
at com.android.vending.billing.IInAppBillingService$Stub$Proxy.getSkuDetails(IInAppBillingService.java:251)
at org.onepf.oms.appstore.googleUtils.IabHelper.querySkuDetails(IabHelper.java:998)
at org.onepf.oms.appstore.googleUtils.IabHelper.queryInventory(IabHelper.java:586)
at org.onepf.oms.OpenIabHelper.queryInventory(OpenIabHelper.java:1399)
at org.onepf.oms.OpenIabHelper$17.run(OpenIabHelper.java:1451)
at java.lang.Thread.run(Thread.java:818)

I am using gdx-pay v0.9.2, unfortunatelly I am not sure how to reproduce that issue.

@noblemaster
Copy link
Member

Did you add the "READ_PHONE_STATE" permission to the AndroidManifest.xml?

Also note, the Open IAB backend is deprecated (because buggy). I suggest switch to the Google Play backend.

@keesvandieren
Copy link
Member

Use gdx-pay-android-googleplay instead.

@centy
Copy link
Author

centy commented Sep 8, 2016

I need SUBSCRIPTION which is not supported by gdx-pay-android-googleplay

czw., 8.09.2016 o 14:27 użytkownik Kees van Dieren notifications@github.com
napisał:

Use gdx-pay-android-googleplay instead.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#111 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjgUuTvE9LcoXy6mPYNSZlZIbBkuQIiks5qn_9NgaJpZM4JRj0C
.

@keesvandieren
Copy link
Member

Aha. I understand. We are sorry, but I cannot help you debugging the openiab implementation (actually did that for my own app without succes, resulting in spending 2 weeks in writing gdx-pay-android-googleplay :) ).

If you have time to create a pull request for subscriptions in gdx-pay-android-googleplay, that would be really great. I am happy to help you with that.

@centy
Copy link
Author

centy commented Nov 10, 2016

Hi,
It looks like I have to add this support for subscriptions, we have a lot
of crashes on old engine. Can you guide me how to start?

@keesvandieren
Copy link
Member

keesvandieren commented Nov 10, 2016

That is great!

Below a brief introduction that helps to get started.

Technologies and methodologies

  • basic knowledge of gradle (e.g. run the check command)
  • basic knowledge of unit-testing / tdd
  • basic knowledge of the Mockito framework (current tests use Mockito 1.x)

The project is maintained using Android Studio, I never tried Eclipse so I am not sure if it is easy to extend with Eclipse.

The unit-tests are created in a Behaviour-driven development style. So each unit-test method describes an expected output for a given event. This discussion might be useful to understand the difference between TDD and BDD: http://softwareengineering.stackexchange.com/questions/135218/what-is-the-difference-between-writing-test-cases-for-bdd-and-tdd

Global Design

The class PurchaseSystem is used as entry point from the app implementing in-app purchasing.

The PurchaseSystem class calls the PurchaseManager implementation currently used, for Android this is AndroidGooglePlayPurchaseManager.

AndroidGooglePlayPurchaseManager interacts with Google Play services In-App-Billing via the class V3GoogleInAppBillingService, which interacts with the weak-typed error-prone Google-Play Services.

Google has a useful page about subscriptions worth reading: https://developer.android.com/google/play/billing/billing_subscriptions.html

Does this info help you? If you really plan to start doing it, lets open a new github issue Add subscription support to gdx-pay-android-googleplay.

Best regards,

Kees

@keesvandieren
Copy link
Member

@centy have you read my previous comment with instructions to get started? Not mentioned you in that post, just need to be sure you got notified.

@centy
Copy link
Author

centy commented Nov 12, 2016

Yes. Thanks
W dniu sob., 12.11.2016 o 11:08 Kees van Dieren notifications@github.com
napisał(a):

@centy https://github.com/centy have you read my previous comment with
instructions to get started? Not mentioned you in that post, just need to
be sure you got notified.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#111 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjgUhIE2WUx2ljOJqQBoFTnCPpzZRJIks5q9ZAegaJpZM4JRj0C
.

@centy
Copy link
Author

centy commented Dec 1, 2016

Pull request was submited here: #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants