Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update world dimensions after loading player #20

Merged
merged 2 commits into from
Feb 11, 2016

Conversation

jameelur
Copy link

@jameelur jameelur commented Feb 5, 2016

The current VideoPlayerAndroid does not adhere to the viewport type that was used in it's instantiation. The changes I've made updates the viewport world dimensions once the media player has been prepared and then update the viewport and camera to display the video in the correct dimensions.

@RBogie
Copy link
Member

RBogie commented Feb 5, 2016

I'll look into the changes tonight, after which I'll probably merge it. Thank you for the contribution!

@RBogie
Copy link
Member

RBogie commented Feb 6, 2016

Indeed the documentation says that it will set the world size to the video size, and the android implementation didn't do this. However, the desktop implementation also does not do this.

Since I'm quite busy at the moment, could you add this as well? Could you also fix the indentation?

@jameelur
Copy link
Author

I'm not quite familiar with the desktop implementation as I haven't tried it out before. So it may be better if you could make that change when you can. But from what I can see, you do set the viewport world size to the video dimensions (line 173).

I've fixed the indentation as requested. My mistake, didn't notice you use tabs instead of whitespace.

RBogie added a commit that referenced this pull request Feb 11, 2016
Update world dimensions after loading player
@RBogie RBogie merged commit dcd5b85 into libgdx:master Feb 11, 2016
@RBogie
Copy link
Member

RBogie commented Feb 11, 2016

Ow yeah, you're right. I totally missed that line. Thank you for the fixes!

@jameelur jameelur deleted the bug/viewport-fix branch February 12, 2016 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants