Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion of error handling #3

Closed
elfring opened this issue May 5, 2014 · 5 comments
Closed

Completion of error handling #3

elfring opened this issue May 5, 2014 · 5 comments

Comments

@elfring
Copy link

elfring commented May 5, 2014

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

@badlogic
Copy link
Member

badlogic commented May 5, 2014

The code sure could use some clean-up in terms of error handling and logging. My excuse: it's a shoddy weekend project :)

I'm happy to accept PRs in that regard, otherwise you'll have to wait for some time until i have the resources to continue working on it.

@elfring
Copy link
Author

elfring commented May 5, 2014

Are you interested to apply aspect-oriented software development?
How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

@NathanSweet
Copy link
Member

I'd say keep it simple.

@badlogic
Copy link
Member

badlogic commented May 5, 2014

As @NathanSweet indicated, i think we should keep this as simple as possible. I do appreciate the benefits of AOP for bigger projects, but it would be quite an overkill for 150 LOC of Java code and 200 LOC of C.

@badlogic
Copy link
Member

Merged into #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants