Skip to content

Commit

Permalink
Remove GEOSPreparedContainsProperlyXY
Browse files Browse the repository at this point in the history
References #677
  • Loading branch information
dbaston committed Sep 24, 2022
1 parent 7b5db8a commit df8b93c
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 43 deletions.
3 changes: 1 addition & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ xxxx-xx-xx
- New things:
- Polygonal coverage operations: CoverageValidator, CoveragePolygonValidator,
CoverageGapFinder, CoverageUnion (JTS-900, Martin Davis & Paul Ramsey)
- CAPI: GEOSPreparedContainsXY, GEOSPreparedContainsProperlyXY,
GEOSPreparedIntersectsXY (GH-677, Dan Baston)
- CAPI: GEOSPreparedContainsXY, GEOSPreparedIntersectsXY (GH-677, Dan Baston)
- Add CoordinateSequenceIterator (GH-685, Dan Baston)

- Fixes/Improvements:
Expand Down
6 changes: 0 additions & 6 deletions capi/geos_c.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1461,12 +1461,6 @@ extern "C" {
return GEOSPreparedContainsProperly_r(handle, pg1, g2);
}

char
GEOSPreparedContainsProperlyXY(const geos::geom::prep::PreparedGeometry* pg1, double x, double y)
{
return GEOSPreparedContainsProperlyXY_r(handle, pg1, x, y);
}

char
GEOSPreparedCoveredBy(const geos::geom::prep::PreparedGeometry* pg1, const Geometry* g2)
{
Expand Down
21 changes: 0 additions & 21 deletions capi/geos_c.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -1124,13 +1124,6 @@ extern char GEOS_DLL GEOSPreparedContainsProperly_r(
const GEOSPreparedGeometry* pg1,
const GEOSGeometry* g2);

/** \see GEOSPreparedContainsProperlyXY */
extern char GEOS_DLL GEOSPreparedContainsProperlyXY_r(
GEOSContextHandle_t handle,
const GEOSPreparedGeometry* pg1,
double x,
double y);

/** \see GEOSPreparedCoveredBy */
extern char GEOS_DLL GEOSPreparedCoveredBy_r(
GEOSContextHandle_t handle,
Expand Down Expand Up @@ -4331,20 +4324,6 @@ extern char GEOS_DLL GEOSPreparedContainsProperly(
const GEOSPreparedGeometry* pg1,
const GEOSGeometry* g2);

/**
* Use a \ref GEOSPreparedGeometry do a high performance
* calculation of whether the provided point is contained properly.
* \param pg1 The prepared geometry
* \param x x coordinate of point to test
* \param y y coordinate of point to test
* \returns 1 on true, 0 on false, 2 on exception
* \see GEOSContainsProperly
*/
extern char GEOS_DLL GEOSPreparedContainsProperlyXY(
const GEOSPreparedGeometry* pg1,
double x,
double y);

/**
* Using a \ref GEOSPreparedGeometry do a high performance
* calculation of whether the provided geometry is covered by.
Expand Down
9 changes: 0 additions & 9 deletions capi/geos_ts_c.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3413,15 +3413,6 @@ extern "C" {
});
}

char
GEOSPreparedContainsProperlyXY_r(GEOSContextHandle_t extHandle,
const geos::geom::prep::PreparedGeometry* pg, double x, double y)
{
extHandle->point2d->setXY(x, y);

return GEOSPreparedContainsProperly_r(extHandle, pg, extHandle->point2d.get());
}

char
GEOSPreparedCoveredBy_r(GEOSContextHandle_t extHandle,
const geos::geom::prep::PreparedGeometry* pg, const Geometry* g)
Expand Down
5 changes: 0 additions & 5 deletions tests/unit/capi/GEOSPreparedGeometryTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -435,11 +435,6 @@ void object::test<15>
ensure_equals(GEOSPreparedContainsXY(prepGeom1_, 1.5, 0.5), 0);
ensure_equals(GEOSPreparedContainsXY(prepGeom1_, 0.75, 0.5), 1);

ensure_equals(GEOSPreparedContainsProperlyXY(prepGeom1_, 0.5, 0.5), 1);
ensure_equals(GEOSPreparedContainsProperlyXY(prepGeom1_, 0, 0), 0);
ensure_equals(GEOSPreparedContainsProperlyXY(prepGeom1_, 1.5, 0.5), 0);
ensure_equals(GEOSPreparedContainsProperlyXY(prepGeom1_, 0.75, 0.5), 1);

ensure_equals(GEOSPreparedIntersectsXY(prepGeom1_, 0.5, 0.5), 1);
ensure_equals(GEOSPreparedIntersectsXY(prepGeom1_, 1.5, 0.5), 0);
ensure_equals(GEOSPreparedIntersectsXY(prepGeom1_, 0.75, 0.5), 1);
Expand Down

0 comments on commit df8b93c

Please sign in to comment.