GEOS compilation fails with Intel compiler

[adamjstewart]

I'm trying to compile GEOS 3.9.1 on CentOS 7 with Intel 19.1.1.217 and I'm getting the following compilation error:

ASLocalizer.cpp(411): error #913: invalid multibyte character sequence
  	addPair("Formatted  %s\n", L"Форматиран  %s\n");		// should align with unchanged
  	                             ^

Here is the full build log.

Any suggestions for how to resolve this issue?

[pramsey]

You could strip out those lines, or even just remove astyle from the cmakelists.txt file entirely. It's only used for code formatting so it's not necessary at all. I have no idea why icc chokes on that character string.

[dbaston]

I wonder if it may be an issue with the build environment or compiler flags, e.g. spack/spack#14450 or https://community.intel.com/t5/Intel-C-Compiler/improper-UTF-8-characters-handling-by-ICC-on-Windows/td-p/1099463

Adding a BUILD_ASTYLE option to the CMake configuration probably makes sense.

[mwtoews]

Adding a BUILD_ASTYLE option to the CMake configuration probably makes sense.

Agree, see gh-461

[adamjstewart]

I switched from the Autotools build to the CMake build and the problem magically went away!

[adamjstewart]

Nevermind, I was using GCC that time. Trying again with Intel...

[mwtoews]

For what it's worth, I'm unable to reproduce the error using the free Intel oneAPI:

mkdir build && cd build
cmake -DCMAKE_C_COMPILER=icc -DCMAKE_CXX_COMPILER=icpc ..
make
ctest

this compiles fine (no errors, no warnings), but fails some of the tests:

The following tests FAILED:
	 12 - unit-algorithm-LocatePointInRing (Failed)
	 15 - unit-algorithm-OrientationIndexFailure (Failed)
	 18 - unit-algorithm-RobustLineIntersector (Failed)
	129 - unit-geom-Triangle (Failed)
	152 - unit-math-DD (Failed)
	166 - unit-operation-distance-DistanceOp (Failed)
	211 - unit-triangulate-Voronoi (Failed)
	244 - general-TestOverlayPLPrec (Failed)
	279 - issue-issue-geos-398 (Failed)
	320 - robust-TestRobustRelate (Failed)
Errors while running CTest

---

With the initial error, it's likely there is something strange going on with non-Latin locales.

[pramsey]

I'm going to guess that the regress fails are related to the unit-math-DD failure at the root, and that failure might be the same as the issue that caused ARM regression, namely some order-of-ops differences in the instructions being generated.

• https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98207#c2
• https://github.com/libgeos/geos/blob/main/CMakeLists.txt#L158

[mwtoews]

I might as well catalogue the 10 excerpts from ctest --output-on-failure here:

 12/377 Test  #12: unit-algorithm-LocatePointInRing .........................***Failed    0.01 sec
===============================
  GEOS Test Suite Application
===============================

geos::algorithm::LocatePointInRing: ....[5=F][6=F][7=F]

---> group: geos::algorithm::LocatePointInRing, test: test<5>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `e` actual `b``

---> group: geos::algorithm::LocatePointInRing, test: test<6>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `i` actual `b``

---> group: geos::algorithm::LocatePointInRing, test: test<7>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `e` actual `b``

tests summary: failures:3 ok:4

 15/377 Test  #15: unit-algorithm-OrientationIndexFailure ...................***Failed    0.01 sec
===============================
  GEOS Test Suite Application
===============================

geos::algorithm::OrientationIndexFailure: .[2=F][3=F].[5=F][6=F].[8=F]

---> group: geos::algorithm::OrientationIndexFailure, test: test<2>
     problem: assertion failed
     failed assertion: `ring orientation test 2 failed: expected `1` actual `0``

---> group: geos::algorithm::OrientationIndexFailure, test: test<3>
     problem: assertion failed
     failed assertion: `ring orientation test 3 failed: expected `1` actual `0``

---> group: geos::algorithm::OrientationIndexFailure, test: test<5>
     problem: assertion failed
     failed assertion: `ring orientation test 5 failed: expected `1` actual `0``

---> group: geos::algorithm::OrientationIndexFailure, test: test<6>
     problem: assertion failed
     failed assertion: `ring orientation test 6 failed: expected `1` actual `0``

---> group: geos::algorithm::OrientationIndexFailure, test: test<8>
     problem: assertion failed
     failed assertion: `ring orientation test 8 failed: expected `1` actual `0``

tests summary: failures:5 ok:3

 18/377 Test  #18: unit-algorithm-RobustLineIntersector .....................***Failed    0.01 sec
===============================
  GEOS Test Suite Application
===============================

geos::algorithm::RobustLineIntersector: ..........[11=F].[13=F]..

---> group: geos::algorithm::RobustLineIntersector, test: test<11>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `1` actual `0``

---> group: geos::algorithm::RobustLineIntersector, test: test<13>
     problem: assertion failed

tests summary: failures:2 ok:13

===============================
  GEOS Test Suite Application
===============================

geos::geom::Triangle: ......[7=F]

---> group: geos::geom::Triangle, test: test<7>
     problem: assertion failed

tests summary: failures:1 ok:6

129/377 Test #129: unit-geom-Triangle .......................................***Failed    0.01 sec
===============================
  GEOS Test Suite Application
===============================

geos::geom::Triangle: ......[7=F]

---> group: geos::geom::Triangle, test: test<7>
     problem: assertion failed

tests summary: failures:1 ok:6

152/377 Test #152: unit-math-DD .............................................***Failed    0.01 sec
===============================
  GEOS Test Suite Application
===============================

geos::math::DD: [1=F][2=F]..[5=F][6=F]....[11=F][12=F][13=F]

---> group: geos::math::DD, test: test<1>
     problem: assertion failed
     failed assertion: `Test PI calculation`

---> group: geos::math::DD, test: test<2>
     problem: assertion failed
     failed assertion: `Test E calculation`

---> group: geos::math::DD, test: test<5>
     problem: assertion failed
     failed assertion: `checkMultiplyDivide`

---> group: geos::math::DD, test: test<6>
     problem: assertion failed
     failed assertion: `checkDivideMultiply`

---> group: geos::math::DD, test: test<11>
     problem: assertion failed
     failed assertion: `checkDeterminant`

---> group: geos::math::DD, test: test<12>
     problem: assertion failed
     failed assertion: `isSame`

---> group: geos::math::DD, test: test<13>
     problem: assertion failed
     failed assertion: `isSame`

tests summary: failures:7 ok:6

166/377 Test #166: unit-operation-distance-DistanceOp .......................***Failed    0.01 sec
===============================
  GEOS Test Suite Application
===============================

geos::operation::distance::DistanceOp: ...................[20=F].

---> group: geos::operation::distance::DistanceOp, test: test<20>
     problem: assertion failed

tests summary: failures:1 ok:20

211/377 Test #211: unit-triangulate-Voronoi .................................***Failed    0.01 sec
===============================
  GEOS Test Suite Application
===============================

geos::triangulate::Voronoi: .........
 Expected: GEOMETRYCOLLECTION (POLYGON ((193602.7711332133 469345.898980198, 193604.4418848486 469348.6016666667, 193605.9466666667 469348.6016666667, 193605.9466666667 469347.7638144172, 193603.2325 469345.391, 193602.9475 469345.391, 193602.8169643859 469345.5051185583, 193602.7711332133 469345.898980198)), POLYGON ((193601.8569454336 469344.9208636514, 193601.865 469344.9666851849, 193602.2037556305 469345.52375, 193602.2585544897 469345.5401343054, 193602.4642389841 469345.148354316, 193602.4577210526 469345.065, 193602.0579897448 469344.3617689955, 193601.8569454336 469344.9208636514)), POLYGON ((193601.2583333333 469342.0043333333, 193601.2583333333 469345.18625, 193601.5616666667 469345.18625, 193601.8569454336 469344.9208636514, 193602.0579897448 469344.3617689955, 193602.0222507725 469343.9301164729, 193601.5161595486 469342.0043333333, 193601.2583333333 469342.0043333333)), POLYGON ((193600.8486366758 469348.6016666667, 193604.4418848486 469348.6016666667, 193602.7711332133 469345.898980198, 193602.3274661311 469345.7182269423, 193601.865 469346.1338755144, 193601.5616666667 469346.6791265432, 193600.8486366758 469348.6016666667)), POLYGON ((193599.3943641253 469348.6016666667, 193600.8486366758 469348.6016666667, 193601.5616666667 469346.6791265432, 193601.5616666667 469345.52375, 193601.2583333333 469345.52375, 193600.955 469345.7963755144, 193599.3943641253 469348.6016666667)), POLYGON ((193602.4577210526 469345.065, 193602.4642389841 469345.148354316, 193602.8169643859 469345.5051185583, 193602.9475 469345.391, 193602.9475 469345.065, 193602.4577210526 469345.065)), POLYGON ((193602.2585544897 469345.5401343054, 193602.3274661311 469345.7182269423, 193602.7711332133 469345.898980198, 193602.8169643859 469345.5051185583, 193602.4642389841 469345.148354316, 193602.2585544897 469345.5401343054)), POLYGON ((193602.0222507725 469343.9301164729, 193602.0579897448 469344.3617689955, 193602.4577210526 469345.065, 193602.9475 469345.065, 193602.9475 469344.739, 193602.0222507725 469343.9301164729)), POLYGON ((193601.865 469345.52375, 193601.865 469346.1338755144, 193602.3274661311 469345.7182269423, 193602.2585544897 469345.5401343054, 193602.2037556305 469345.52375, 193601.865 469345.52375)), POLYGON ((193601.5616666667 469345.18625, 193601.5616666667 469345.52375, 193601.865 469345.52375, 193601.865 469344.9666851849, 193601.8569454336 469344.9208636514, 193601.5616666667 469345.18625)), POLYGON ((193601.5161595486 469342.0043333333, 193602.0222507725 469343.9301164729, 193602.9475 469344.739, 193603.2325 469344.739, 193603.2325 469342.0043333333, 193601.5161595486 469342.0043333333)), POLYGON ((193598.2316666667 469345.18625, 193598.2316666667 469348.6016666667, 193599.3943641253 469348.6016666667, 193600.955 469345.7963755144, 193600.955 469345.18625, 193598.2316666667 469345.18625)), POLYGON ((193603.2325 469345.065, 193603.2325 469345.391, 193605.9466666667 469347.7638144172, 193605.9466666667 469345.065, 193603.2325 469345.065)), POLYGON ((193603.2325 469344.739, 193603.2325 469345.065, 193605.9466666667 469345.065, 193605.9466666667 469344.739, 193603.2325 469344.739)), POLYGON ((193603.2325 469342.0043333333, 193603.2325 469344.739, 193605.9466666667 469344.739, 193605.9466666667 469342.0043333333, 193603.2325 469342.0043333333)), POLYGON ((193602.9475 469345.065, 193602.9475 469345.391, 193603.2325 469345.391, 193603.2325 469345.065, 193602.9475 469345.065)), POLYGON ((193602.9475 469344.739, 193602.9475 469345.065, 193603.2325 469345.065, 193603.2325 469344.739, 193602.9475 469344.739)), POLYGON ((193601.5616666667 469345.52375, 193601.5616666667 469346.6791265432, 193601.865 469346.1338755144, 193601.865 469345.52375, 193601.5616666667 469345.52375)), POLYGON ((193601.2583333333 469345.18625, 193601.2583333333 469345.52375, 193601.5616666667 469345.52375, 193601.5616666667 469345.18625, 193601.2583333333 469345.18625)), POLYGON ((193600.955 469345.18625, 193600.955 469345.7963755144, 193601.2583333333 469345.52375, 193601.2583333333 469345.18625, 193600.955 469345.18625)), POLYGON ((193600.955 469342.0043333333, 193600.955 469345.18625, 193601.2583333333 469345.18625, 193601.2583333333 469342.0043333333, 193600.955 469342.0043333333)), POLYGON ((193598.2316666667 469342.0043333333, 193598.2316666667 469345.18625, 193600.955 469345.18625, 193600.955 469342.0043333333, 193598.2316666667 469342.0043333333)), POLYGON ((193601.865 469344.9666851849, 193601.865 469345.52375, 193602.2037556305 469345.52375, 193601.865 469344.9666851849)))
 Obtained: GEOMETRYCOLLECTION (GEOMETRYCOLLECTION (POLYGON ((193601.5161595486 469342.00433333335, 193602.02225077248 469343.9301164729, 193602.9475 469344.739, 193603.23249999998 469344.739, 193603.23249999998 469342.00433333335, 193601.5161595486 469342.00433333335)), LINESTRING (193603.23249999998 469344.739, 193603.2325 469344.739)), GEOMETRYCOLLECTION (POLYGON ((193598.2316666667 469345.18625, 193598.2316666667 469348.6016666667, 193599.3943641253 469348.6016666667, 193600.955 469345.79637551436, 193600.955 469345.18625, 193598.2316666667 469345.18625)), LINESTRING (193600.955 469345.18624999997, 193600.955 469345.18625)), GEOMETRYCOLLECTION (POLYGON ((193603.23249999998 469345.391, 193605.94666666666 469347.76381441724, 193605.94666666666 469345.065, 193603.2325 469345.065, 193603.23249999998 469345.391)), LINESTRING (193603.23249999998 469345.065, 193603.2325 469345.065)), GEOMETRYCOLLECTION (POLYGON ((193603.23249999998 469345.065, 193605.94666666666 469345.065, 193605.94666666666 469344.739, 193603.2325 469344.739, 193603.23249999998 469345.065)), LINESTRING (193603.23249999998 469344.739, 193603.2325 469344.739)), GEOMETRYCOLLECTION (POLYGON ((193600.955 469345.18624999997, 193601.25833333333 469345.18625, 193601.25833333333 469342.00433333335, 193600.95500000002 469342.00433333335, 193600.955 469345.18624999997)), LINESTRING (193600.955 469345.18624999997, 193600.955 469345.18625)), POLYGON ((193602.7711332133 469345.898980198, 193604.44188484858 469348.6016666667, 193605.94666666666 469348.6016666667, 193605.94666666666 469347.76381441724, 193603.23249999998 469345.391, 193602.94749999998 469345.391, 193602.81696438594 469345.5051185583, 193602.7711332133 469345.898980198)), POLYGON ((193601.85694543357 469344.92086365144, 193601.865 469344.9666851849, 193602.20375563053 469345.52375, 193602.2585544897 469345.54013430537, 193602.4642389841 469345.14835431596, 193602.45772105263 469345.065, 193602.0579897448 469344.3617689955, 193601.85694543357 469344.92086365144)), POLYGON ((193601.25833333333 469342.00433333335, 193601.25833333333 469345.18625, 193601.56166666668 469345.18624999997, 193601.85694543357 469344.92086365144, 193602.0579897448 469344.3617689955, 193602.02225077248 469343.9301164729, 193601.5161595486 469342.00433333335, 193601.25833333333 469342.00433333335)), POLYGON ((193600.84863667577 469348.6016666667, 193604.44188484858 469348.6016666667, 193602.7711332133 469345.898980198, 193602.32746613107 469345.7182269423, 193601.86500000002 469346.1338755144, 193601.56166666668 469346.67912654317, 193600.84863667577 469348.6016666667)), POLYGON ((193599.3943641253 469348.6016666667, 193600.84863667577 469348.6016666667, 193601.56166666668 469346.67912654317, 193601.56166666668 469345.52375, 193601.25833333333 469345.52375, 193600.955 469345.79637551436, 193599.3943641253 469348.6016666667)), POLYGON ((193602.94749999998 469345.065, 193603.2325 469345.065, 193603.23249999998 469345.065, 193603.2325 469344.739, 193602.9475 469344.739, 193602.94749999998 469345.065)), POLYGON ((193602.45772105263 469345.065, 193602.4642389841 469345.14835431596, 193602.81696438594 469345.5051185583, 193602.94749999998 469345.391, 193602.94749999998 469345.065, 193602.45772105263 469345.065)), POLYGON ((193602.2585544897 469345.54013430537, 193602.32746613107 469345.7182269423, 193602.7711332133 469345.898980198, 193602.81696438594 469345.5051185583, 193602.4642389841 469345.14835431596, 193602.2585544897 469345.54013430537)), POLYGON ((193602.02225077248 469343.9301164729, 193602.0579897448 469344.3617689955, 193602.45772105263 469345.065, 193602.94749999998 469345.065, 193602.9475 469344.739, 193602.02225077248 469343.9301164729)), POLYGON ((193601.86500000002 469345.52375, 193601.86500000002 469346.1338755144, 193602.32746613107 469345.7182269423, 193602.2585544897 469345.54013430537, 193602.20375563053 469345.52375, 193601.86500000002 469345.52375)), POLYGON ((193601.56166666668 469345.52375, 193601.56166666668 469346.67912654317, 193601.86500000002 469346.1338755144, 193601.86500000002 469345.52375, 193601.865 469345.52375, 193601.56166666668 469345.52375)), POLYGON ((193601.56166666668 469345.18624999997, 193601.56166666668 469345.52375, 193601.865 469345.52375, 193601.865 469344.9666851849, 193601.85694543357 469344.92086365144, 193601.56166666668 469345.18624999997)), POLYGON ((193603.23249999998 469342.00433333335, 193603.23249999998 469344.739, 193605.94666666666 469344.739, 193605.94666666666 469342.00433333335, 193603.23249999998 469342.00433333335)), POLYGON ((193602.94749999998 469345.065, 193602.94749999998 469345.391, 193603.23249999998 469345.391, 193603.2325 469345.065, 193602.94749999998 469345.065)), POLYGON ((193601.865 469344.9666851849, 193601.865 469345.52375, 193601.86500000002 469345.52375, 193602.20375563053 469345.52375, 193601.865 469344.9666851849)), POLYGON ((193601.25833333333 469345.18625, 193601.25833333333 469345.52375, 193601.56166666668 469345.52375, 193601.56166666668 469345.18624999997, 193601.25833333333 469345.18625)), POLYGON ((193600.955 469345.18624999997, 193600.955 469345.79637551436, 193601.25833333333 469345.52375, 193601.25833333333 469345.18625, 193600.955 469345.18624999997)), POLYGON ((193598.2316666667 469342.00433333335, 193598.2316666667 469345.18625, 193600.955 469345.18625, 193600.95500000002 469342.00433333335, 193598.2316666667 469342.00433333335)))
[10=F]

---> group: geos::triangulate::Voronoi, test: test<10>
     problem: assertion failed

tests summary: failures:1 ok:9

244/377 Test #244: general-TestOverlayPLPrec ................................***Failed    0.01 sec
/home/mtoews/src/GEOS/geos-git/tests/xmltester/tests/general/TestOverlayPLPrec.xml: case1: test1: intersects(A, B): failed. (0 ms)
	Description: PP - Point just off line. Causes non-robust algorithms to fail.
	Geometry A: 01020000000200000000000054346F9DC100000000000044C0B074E3A2DAA8F54200000054346F9D41
	Geometry B: 010100000000000000000000000000000000000000
	Expected result: false
	Obtained result: true

Files: 1
Tests: 1
Failed: 1
Succeeded: 0

279/377 Test #279: issue-issue-geos-398 .....................................***Failed    0.01 sec
Using an overlay tolerance of 3.6e-08
/home/mtoews/src/GEOS/geos-git/tests/xmltester/tests/issue/issue-geos-398.xml: case1: test1: union(A, B): failed. (0 ms)
	Description: http://trac.osgeo.org/geos/ticket/398
Assertion `shellCount <= 1' failed.
	Geometry A: 010600000003000000010300000001000000090000000000000000004E403AE8917AC40A1A4080C8D9FE92004640401E2C34E262274000000000000000008DD9C34166F339400000000000000000340FE0365FDC3A400000000000000000E6E7A017BBD63D400000000000004E40CA1003E90BCC24400000000000004E4088D70EC362351F400000000000004E40052475CADEA01A400000000000004E403AE8917AC40A1A40010300000001000000090000005D2FA99C76A845400000000000000000000000000000000000000000000000000000000000000000E4FF0AD7B8112C400000000000000000A52CF2D833EC31400000000000000000841D588465963540F56BFB214F0341408F26B714B2971B405D2FA99C76A84B400000000000000000097AECB49100494000000000000000005D2FA99C76A8454000000000000000000103000000010000000800000066BF3C1522E42A4000000000000042400000000000004E4000000000000042400000000000004E40CC47F33161CB30400000000000004E408289E564495D30400000000000004E40FCE9CFA586162C4000D8FA98AB59074000000000000042408E60CC0601CA2740000000000000424066BF3C1522E42A400000000000004240
	Geometry B: 01030000000100000006000000097AECB49100494000000000000000000000000000000000841D5884659635400000000000000000F5183D909EDE41400000000000004E40D4F09871275E2A400000000000004E400000000000000000097AECB4910049400000000000000000
	Expected result: 01060000000200000001030000000200000012000000000000000000000000000000000000000000000000000000E4FF0AD7B8112C400000000000000000A52CF2D833EC31400000000000000000841D58846596354000000000000000008DD9C34166F339400000000000000000340FE0365FDC3A400000000000000000E6E7A017BBD63D400000000000000000F5183D909EDE41400000000000004E40D4F09871275E2A400000000000004E40CA1003E90BCC24400000000000004E4088D70EC362351F400000000000004E40052475CADEA01A400000000000004E403AE8917AC40A1A400000000000004E4000000000000000005D2FA99C76A84B400000000000000000097AECB49100494000000000000000005D2FA99C76A84540000000000000000000000000000000000000000000000000040000000000000000000000841D588465963540F56BFB214F0341408F26B714B2971B40F66BFB214F0341408E26B714B2971B400000000000000000841D5884659635400103000000010000000800000000D8FA98AB59074000000000000042408E60CC0601CA2740000000000000424066BF3C1522E42A4000000000000042400000000000004E4000000000000042400000000000004E40CC47F33161CB30400000000000004E408289E564495D30400000000000004E40FCE9CFA586162C4000D8FA98AB5907400000000000004240
	Obtained result: 01060000000200000001030000000100000012000000000000000000000000000000000000000000000000000000E4FF0AD7B8112C400000000000000000A52CF2D833EC31400000000000000000841D58846596354000000000000000008DD9C34166F339400000000000000000340FE0365FDC3A400000000000000000E6E7A017BBD63D400000000000000000F5183D909EDE41400000000000004E40D4F09871275E2A400000000000004E40CA1003E90BCC24400000000000004E4088D70EC362351F400000000000004E40052475CADEA01A400000000000004E403AE8917AC40A1A400000000000004E4000000000000000005D2FA99C76A84B400000000000000000097AECB49100494000000000000000005D2FA99C76A845400000000000000000000000000000000000000000000000000103000000010000000800000000D8FA98AB59074000000000000042408E60CC0601CA2740000000000000424066BF3C1522E42A4000000000000042400000000000004E4000000000000042400000000000004E40CC47F33161CB30400000000000004E408289E564495D30400000000000004E40FCE9CFA586162C4000D8FA98AB5907400000000000004240

Files: 1
Tests: 1
Failed: 1
Succeeded: 0

320/377 Test #320: robust-TestRobustRelate ..................................***Failed    0.01 sec
/home/mtoews/src/GEOS/geos-git/tests/xmltester/tests/robust/TestRobustRelate.xml: case1: test1: intersects(A, B): failed. (0 ms)
	Description: PP - Point is not on line. Non-robust algorithms fail by erroneously reporting intersects=true.
	Geometry A: 01020000000200000000000054346F9DC100000000000044C0B074E3A2DAA8F54200000054346F9D41
	Geometry B: 010100000000000000000000000000000000000000
	Expected result: false
	Obtained result: true

Files: 1
Tests: 1
Failed: 1
Succeeded: 0

The bright side of this is that 97% tests passed, only 10 tests failed out of 377.

[adamjstewart]

Okay, I'm able to build GEOS with Intel with #461 and -DBUILD_ASTYLE=OFF. I'm fine with this solution, but I'll let you decide if you want to keep debugging the astyle build error.

[pramsey]

No, a little too niche.