Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferBuilder::computeNodedEdges is uninterruptible (and can be slow) #894

Closed
strk opened this issue May 4, 2023 · 3 comments
Closed

BufferBuilder::computeNodedEdges is uninterruptible (and can be slow) #894

strk opened this issue May 4, 2023 · 3 comments

Comments

@strk
Copy link
Member

strk commented May 4, 2023

The computeNodedEdges step in BufferBuilder can take a long time and there's no way to interrupt it at the moment.
Downstream issue: https://trac.osgeo.org/postgis/ticket/5379
@strk
Copy link
Member Author

strk commented May 4, 2023

Culprit is the MCIndexNoder::intersectChains method

strk added a commit that referenced this issue May 4, 2023
@strk
Make MCIndexNoder::intersectChains interruptible
20ca29f 
Improves interruptability of BufferBuilder::computeNodedEdges
References GH-894 in main branch ( 3.12.0dev )
@pramsey
Copy link
Member

pramsey commented May 4, 2023

Is STRTree::queryPairs being run with a very large numItems? If so, maybe an interupt test modulo 1000 or something?

@strk
Copy link
Member Author

strk commented May 4, 2023

Fixed with 20ca29f
It was broken by a recent d210a94 (referencing PR GH-736)

@strk strk closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pramsey @strk