Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.12.0: tests GEOSWKBWriter and WKBWriter fail on s390x #934

Closed
hjaekel opened this issue Jun 30, 2023 · 2 comments
Closed

3.12.0: tests GEOSWKBWriter and WKBWriter fail on s390x #934

hjaekel opened this issue Jun 30, 2023 · 2 comments

Comments

@hjaekel
Copy link

hjaekel commented Jun 30, 2023

On s390x (big endian architecture), the tests for GEOSWKBWriter and WKBWriter fail with geos 3.12.0. Here is the log output of the failure:

147/466 Test #147: unit-capi-GEOSWKBWriter ....................................***Failed    0.01 sec
===============================
  GEOS Unit Test Suite
===============================

capi::GEOSWKBWriter: .[2=F][3=F][4=F].[6=F][7=F][8=F][9=F]

---> group: capi::GEOSWKBWriter, test: test<2>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `010100000000000000000008400000000000002040` actual `000000000140080000000000004020000000000000``

---> group: capi::GEOSWKBWriter, test: test<3>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `0101000020917D000000000000000008400000000000002040` actual `002000000100007D9140080000000000004020000000000000``

---> group: capi::GEOSWKBWriter, test: test<4>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `01010000A0917D0000000000000000084000000000000020400000000000000000` actual `00A000000100007D91400800000000000040200000000000000000000000000000``

---> group: capi::GEOSWKBWriter, test: test<6>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `010100000000000000000008400000000000002040` actual `000000000140080000000000004020000000000000``

---> group: capi::GEOSWKBWriter, test: test<7>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `0101000040000000000000084000000000000020400000000000000040` actual `0040000001400800000000000040200000000000004000000000000000``

---> group: capi::GEOSWKBWriter, test: test<8>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `010100000000000000000008400000000000002040` actual `000000000140080000000000004020000000000000``

---> group: capi::GEOSWKBWriter, test: test<9>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `010100008000000000000008400000000000002040000000000000F03F` actual `0080000001400800000000000040200000000000003FF0000000000000``

tests summary: failures:7 ok:2
216/466 Test #216: unit-io-WKBWriter ..........................................***Failed    0.01 sec
===============================
  GEOS Unit Test Suite
===============================

geos::io::WKBWriter: ..........[11=F][12=F]

---> group: geos::io::WKBWriter, test: test<11>
     problem: assertion failed
     failed assertion: `XYZM ISO: expected `01BA0B000002000000000000000000F03F000000000000004000000000000008400000000000001040000000000000144000000000000018400000000000001C400000000000002040` actual `0000000BBA000000023FF000000000000040000000000000004008000000000000401000000000000040140000000000004018000000000000401C0000000000004020000000000000``

---> group: geos::io::WKBWriter, test: test<12>
     problem: assertion failed
     failed assertion: `XYM ISO: expected `01D207000002000000000000000000F03F00000000000000400000000000000840000000000000104000000000000014400000000000001840` actual `00000007D2000000023FF000000000000040000000000000004008000000000000401000000000000040140000000000004018000000000000``

tests summary: failures:2 ok:10

The same tests are successful on all little endian platforms with 3.12.0.

pramsey added a commit that referenced this issue Jun 30, 2023
@hjaekel
Copy link
Author

hjaekel commented Jul 1, 2023

With your patch, one test still fails:

146/466 Test #147: unit-capi-GEOSWKBWriter ....................................***Failed    0.01 sec
===============================
  GEOS Unit Test Suite
===============================
capi::GEOSWKBWriter: [1=F]........
---> group: capi::GEOSWKBWriter, test: test<1>
     problem: assertion failed
     failed assertion: `Values are not equal: expected `0` actual `1``
tests summary: failures:1 ok:8
        Start 154: unit-capi-GEOSisValidReason

pramsey added a commit that referenced this issue Jul 1, 2023
pramsey added a commit that referenced this issue Jul 1, 2023
@hjaekel
Copy link
Author

hjaekel commented Jul 5, 2023

Thank you, all test are successful now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant