GEOS 3.8 is also failing

[robe2]

This one seems to be caused by the compilers becoming more pedantic. Complaining about variables defined and not used etc. https://github.com/libgeos/geos/actions/runs/6837999164/job/18594608439

As far as I can tell, no code has changed since the last successful run.

[ 17%] Building CXX object CMakeFiles/geos.dir/src/geomgraph/Depth.cpp.o
In file included from /home/runner/work/geos/geos/src/geomgraph/Depth.cpp:24:
In file included from /home/runner/work/geos/geos/include/geos/geomgraph/Label.h:26:
/home/runner/work/geos/geos/include/geos/geomgraph/TopologyLocation.h:133:10: error: no type named 'uint8_t' in namespace 'std'
    std::uint8_t locationSize;
    ~~~~~^
In file included from /home/runner/work/geos/geos/src/geomgraph/Depth.cpp:24:
In file included from /home/runner/work/geos/geos/include/geos/geomgraph/Label.h:26:
In file included from /home/runner/work/geos/geos/include/geos/geomgraph/TopologyLocation.h:142:
/home/runner/work/geos/geos/include/geos/geomgraph/TopologyLocation.inl:109:21: warning: implicit conversion changes signedness: 'int' to 'std::array::size_type' (aka 'unsigned long') [-Wsign-conversion]
    return location[locIndex] == le.location[locIndex];
           ~~~~~~~~ ^~~~~~~~
/home/runner/work/geos/geos/include/geos/geomgraph/TopologyLocation.inl:109:46: warning: implicit conversion changes signedness: 'int' to 'std::array::size_type' (aka 'unsigned long') [-Wsign-conversion]
    return location[locIndex] == le.location[locIndex];
                                 ~~          ^~~~~~~~
2 warnings and 1 error generated.
make[2]: *** [CMakeFiles/geos.dir/build.make:1154: CMakeFiles/geos.dir/src/geomgraph/Depth.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/runner/work/geos/geos/src/geom/util/SineStarFactory.cpp:59:38: warning: implicit conversion changes signedness: 'int' to 'std::vector::size_type' (aka 'unsigned long') [-Wsign-conversion]
    std::vector<Coordinate> pts(nPts + 1);
                            ~~~ ~~~~~^~~
/home/runner/work/geos/geos/src/geom/util/SineStarFactory.cpp:79:16: warning: implicit conversion changes signedness: 'int' to 'std::vector::size_type' (aka 'unsigned long') [-Wsign-conversion]
        pts[iPt++] = coord(x, y);
        ~~~ ~~~^~
/home/runner/work/geos/geos/src/geom/util/SineStarFactory.cpp:81:9: warning: implicit conversion changes signedness: 'int' to 'std::vector::size_type' (aka 'unsigned long') [-Wsign-conversion]
    pts[iPt] = pts[0];
    ~~~ ^~~
3 warnings generated.
make[1]: *** [CMakeFiles/Makefile2:438: CMakeFiles/geos.dir/all] Error 2