Performance improvement #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thms::isPointInRing
|
Interestingly, this performance improvement has been in JTS for a long time. So not sure why it wasn't ported. Also, this class is still out of synch with the current JTS code, although not sure how much that matters. |
|
Accidentally added more commits... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First check envelope before calling CGAlgorithms::isPointInRing
Performance of st_intersection went from 15.8 to 11.5 seconds for these polygons:
Polygons.zip
It can be improved even more, but not familiar enough with the code to do that right now.
When calculating the st_intersection, there were still 8526 calls to isPointInRing for a polygon with 5 points, and 4262 calls to isPointInRing for a polygon with 130327 points so perhaps a IndexedPointInAreaLocator or a SIRtreePointInRing can be added to the OverlayOp::computeLabelling() so that it can be used in EdgeEndStar::getLocation