Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch nan/inf arguments to buffering sooner. #663

Closed
wants to merge 7 commits into from

Conversation

pramsey
Copy link
Member

@pramsey pramsey commented Aug 18, 2022

Report exceptions in geosop instead of dying
References #661.

@pramsey pramsey requested a review from dr-jts August 18, 2022 19:51
Copy link
Contributor

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording nit to choose the shorter exception message, used for BufferOp in this PR.

Looks good, and nice to not have "Aborted (core dumped)" from geosop!

src/operation/buffer/BufferBuilder.cpp Outdated Show resolved Hide resolved
src/operation/buffer/BufferBuilder.cpp Outdated Show resolved Hide resolved
src/operation/buffer/OffsetCurve.cpp Outdated Show resolved Hide resolved
src/operation/buffer/OffsetCurve.cpp Outdated Show resolved Hide resolved
pramsey and others added 5 commits August 18, 2022 15:50
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants