Fix crash in GEOSIntersects with empty point inputs #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
added a commit
that referenced
this pull request
Sep 12, 2022
dbaston
added a commit
that referenced
this pull request
Sep 12, 2022
dbaston
added a commit
that referenced
this pull request
Sep 12, 2022
dbaston
added a commit
that referenced
this pull request
Sep 12, 2022
dbaston
added a commit
that referenced
this pull request
Sep 12, 2022
dbaston
added a commit
that referenced
this pull request
Sep 12, 2022
|
Probably needs a NEWS entry? |
dr-jts
reviewed
Sep 12, 2022
| void object::test<7> | ||
| () | ||
| { | ||
| std::string wkb1 = "0103000080010000000C000000D76CFA7C7CF3FFC1B982482636CDCBC15EC31B0E65B6C1C12E877662F4E700C2103B2D82C78DCFC1A29779FE5D09E1C123CB6770DEF3FFC1FCDADA768882CBC17A8FA0B9C080CBC1482374FCF95200C26C3E6539D010EB41502415824E2BDCC1F846A740265CFCC1849036017A69EC41C0AE6BA9836DB6C1B03E5F6E25BBEFC16CB0BE5B0C05E54156D5BAAB3988FDC1887692F5A0B5E1C14E5950599AB8C6413600EDEF3251F3C1483B4D575A32FF417C70666B8C74EB410A04298CBF8AE7C1AEEB2DC41939E1C16D2B823AAC97C441FCE7F04C7BBDE0C184D82356622AEA4161A19916C828F5C1414C7E9080C9FAC12A178C59F5F0FEC1668C89B9F61CFCC1E8964B49B6FEEC41D76CFA7C7CF3FFC1B982482636CDCBC15EC31B0E65B6C1C1"; |
There was a problem hiding this comment.
Would be nicer to use WKT here, so it's obvious that the input has en EMPTY element.
There was a problem hiding this comment.
The following test uses WKT for clarity. This test uses the geometry from the ticket.
|
@dbaston Bug fixes should have NEWS entries for each minor version affected, surely? We should decide on this policy and document it on a page on the website. |
Happy to go along with any policy on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://trac.osgeo.org/geos/ticket/1110