Fix LineSegment.orientationIndex(LineSegment) #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramsey
reviewed
Oct 11, 2022
| @@ -186,7 +186,7 @@ LineSegment::orientationIndex(const LineSegment& seg) const | |||
| } | |||
| // this handles the case where the points are R or collinear | |||
| if(orient0 <= 0 && orient1 <= 0) { | |||
| return std::max(orient0, orient1); | |||
| return std::min(orient0, orient1); | |||
dr-jts
added a commit
that referenced
this pull request
Oct 11, 2022
dr-jts
added a commit
that referenced
this pull request
Oct 11, 2022
|
Love a two character fix...
Meaning there's no unit test ? :)
|
|
There's several! But the fix is two-char. |
dbaston
pushed a commit
to dbaston/libgeos
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
LineSegment.orientationIndex(LineSegment)to have correct result for the case of a non-collinear segment on the right side of the target segment.Port of locationtech/jts#914