Fix TopologyPreservingSimplifier to produce stable results for Multi inputs #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-jts
changed the title
|
Big win! No more random CI failures on different platforms. |
dr-jts
added a commit
that referenced
this pull request
Oct 28, 2022
dr-jts
added a commit
that referenced
this pull request
Oct 28, 2022
dr-jts
added a commit
that referenced
this pull request
Oct 28, 2022
BuonOmo
pushed a commit
to BuonOmo/geos
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
TopologyPreservingSimplifierto have a deterministic ordering for processing Multi-geometries, thus ensuring simplified results are stable.Fixes #667
This may also fix GEOS-1081 - will have to test and see.
Also, the code now produces what looks like incorrect results for test 14. Although JTS produces the same result. More investigation is required to see if this is a bug.