Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust Delaunay Triangulation frame size heuristic #728

Merged
merged 2 commits into from Nov 8, 2022

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented Nov 8, 2022

Increases the size of the "frame" used to initialize the Incremental Delaunay Triangulation subdivision. This improves the robustness of constructing triangulations which contain very narrow triangles along the edge of the subdivision.

Originally reported as a failure in the Concave Hull algorithm in #719. The failure was caused by the constructed triangulation failing to contain triangles which covered the convex hull of the input.

Fixes #719

@dr-jts dr-jts added the Bug label Nov 8, 2022
@dr-jts dr-jts self-assigned this Nov 8, 2022
@dr-jts dr-jts merged commit 1e93736 into libgeos:main Nov 8, 2022
@dr-jts dr-jts deleted the fix-delaunay-frame-size branch November 8, 2022 19:26
BuonOmo pushed a commit to BuonOmo/geos that referenced this pull request Nov 10, 2022
ptitjano added a commit to ptitjano/QGIS that referenced this pull request Aug 2, 2023
ptitjano added a commit to ptitjano/QGIS that referenced this pull request Aug 2, 2023
ptitjano added a commit to ptitjano/QGIS that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geos::algorithm::hull::ConcaveHull::concaveHullByLength segfault
1 participant