GEOSClipByRect: Fix case with POINT EMPTY, add more tests #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
force-pushed
the
fix-clip-by-rect-with-point-empty
branch
from
f18dbbd
to
d786adb
Compare
mwtoews
force-pushed
the
fix-clip-by-rect-with-point-empty
branch
from
d786adb
to
7ffc92a
Compare
mwtoews
added a commit
that referenced
this pull request
May 30, 2023
mwtoews
added a commit
that referenced
this pull request
May 30, 2023
mwtoews
added a commit
that referenced
this pull request
May 30, 2023
mwtoews
added a commit
that referenced
this pull request
May 30, 2023
mwtoews
added a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be an old bug, where
GEOSClipByRect("POINT EMPTY", ...)raises:Other empty combinations work fine (they only return
GEOMETRYCOLLECTION EMPTY), so add each empty combination to the tests.