Add PrecisionReducer test for CoordinateSequence.add bug

[dr-jts]

Issue #811 is caused by a bug in a CoordinateSequence::add method, which is called from SegmentNodeList.addEdgeCoordinates during snap-rounding noding. #963 fixes this issue.

This PR adds a unit test using the case in #811.

Demonstration of Bug

If the original code is used with the debug trace statements in SegmentNodeList.addEdgeCoordinates, the test:

bin/test_geos_unit geos::operation::overlayng::PrecisionReducer 15

produces:

addEdgeCoordinates: (127.117461568 34.562519572, 127.117461568 34.562519572)
updated coord list: (127.117461568 34.562519572)

addEdgeCoordinates: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359)
updated coord list: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359)

addEdgeCoordinates: (127.117607012 34.562312359, 127.117607152 34.562312309, 127.117607012 34.562312359, 127.117254733 34.5621607510001, 127.117746661 34.5620659730001, 127.117603496 34.5623196400001, 127.117484065 34.562488982, 127.117462315 34.562520066, 127.117461568 34.562519572)
updated coord list: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359, 127.117607152 34.562312309, 127.117254733 34.5621607510001, 127.117746661 34.5620659730001, 127.117603496 34.5623196400001, 127.117484065 34.562488982, 127.117462315 34.562520066, 127.117461568 34.562519572)

addEdgeCoordinates: (127.117461568 34.562519572, 127.117245225 34.562385186, 127.117461568 34.562519572)
updated coord list: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359, 127.117607152 34.562312309, 127.117254733 34.5621607510001, 127.117746661 34.5620659730001, 127.117603496 34.5623196400001, 127.117484065 34.562488982, 127.117462315 34.562520066, 127.117461568 34.562519572, 127.117245225 34.562385186)

geos::operation::overlayng::PrecisionReducer: [15=X]

---> group: geos::operation::overlayng::PrecisionReducer, test: test<15>
     problem: unexpected exception
     exception typeid: N4geos4util17TopologyExceptionE
     message: `TopologyException: Ring edge missing at 127.11745999999999 34.562519999999999`

Note that in the final call to addEdgeCoordinates the last coordinate 127.117461568 34.562519572 of the added coordinates is not present in the result coordinates.

Using the new code the trace is:

addEdgeCoordinates: (127.117461568 34.562519572, 127.117461568 34.562519572)
updated coord list: (127.117461568 34.562519572)

addEdgeCoordinates: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359)
updated coord list: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359)

addEdgeCoordinates: (127.117607012 34.562312359, 127.117607152 34.562312309, 127.117607012 34.562312359, 127.117254733 34.5621607510001, 127.117746661 34.5620659730001, 127.117603496 34.5623196400001, 127.117484065 34.562488982, 127.117462315 34.562520066, 127.117461568 34.562519572)
updated coord list: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359, 127.117607152 34.562312309, 127.117607012 34.562312359, 127.117254733 34.5621607510001, 127.117746661 34.5620659730001, 127.117603496 34.5623196400001, 127.117484065 34.562488982, 127.117462315 34.562520066, 127.117461568 34.562519572)

addEdgeCoordinates: (127.117461568 34.562519572, 127.117245225 34.562385186, 127.117461568 34.562519572)
updated coord list: (127.117461568 34.562519572, 127.117483252 34.5624884690001, 127.117603304 34.562319127, 127.117607012 34.562312359, 127.117607152 34.562312309, 127.117607012 34.562312359, 127.117254733 34.5621607510001, 127.117746661 34.5620659730001, 127.117603496 34.5623196400001, 127.117484065 34.562488982, 127.117462315 34.562520066, 127.117461568 34.562519572, 127.117245225 34.562385186, 127.117461568 34.562519572)

geos::operation::overlayng::PrecisionReducer: .

tests summary: ok:1

Fixes #811.

[dbaston]

Are you planning to extract a CoordinateSequence test case, or should I do that?

[dr-jts]

I'm happy for you to take a crack at it, if you're going to work on this issue.

…

On Thu., Sep. 21, 2023, 1:04 p.m. Dan Baston, ***@***.***> wrote: Are you planning to extract a CoordinateSequence test case, or should I do that? — Reply to this email directly, view it on GitHub <#962 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA25SXIBBTRUSWRHCF2JLT3X3SMVNANCNFSM6AAAAAA5B7GBJU> . You are receiving this because you authored the thread.Message ID: ***@***.***>