Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE_BUILD_TYPE should not get overwriten if empty #5934

Open
FFY00 opened this issue Jul 2, 2021 · 0 comments
Open

CMAKE_BUILD_TYPE should not get overwriten if empty #5934

FFY00 opened this issue Jul 2, 2021 · 0 comments

Comments

@FFY00
Copy link

FFY00 commented Jul 2, 2021

As documented, CMAKE_BUILD_TYPE being empty is a valid value with its own behavior (do not touch the compile flags, just use the CFLAGS/CXXFLAGS/etc specified in the environment). libgit2 is overwriting the option to Debug if empty, changing the expected behavior.
Would it be possible for you to consider removing this?

libgit2/CMakeLists.txt

Lines 254 to 256 in e167476

IF (NOT CMAKE_BUILD_TYPE)
SET(CMAKE_BUILD_TYPE "Debug" CACHE STRING "Choose the type of build, options are: Debug Release RelWithDebInfo MinSizeRel." FORCE)
ENDIF ()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant