Unittest offline/worktree::worktree failes in version 1.4.X on Ubuntu

[bebuch]

Reproduction steps

If you want a reproducible clean environment your can use docker on most x86-64 systems:

docker run -it --rm ubuntu:22.04

Inside (dockered) Ubuntu exec:

apt update
apt install -y gcc g++ cmake curl libssl-dev python3
LIBGIT2_VERSION=1.4.3
cd /mnt
curl -L "https://github.com/libgit2/libgit2/archive/refs/tags/v${LIBGIT2_VERSION}.tar.gz" | tar xz
mkdir -p cd /mnt/build && cd $_
cmake /mnt/libgit2-${LIBGIT2_VERSION}
cmake --build . --parallel
ctest -V

Expected behavior

Passing all unit tests.

Actual behavior

Run as normal user:

[…]
1: worktree::worktree...................................
1: 
1:   1) Failure:
1: refs::revparse::date [/home/bebuch/media/tmp/tmp5/libgit2-1.4.3/tests/refs/revparse.c:28]
1:   String mismatch: objstr != expected_oid
1:   'a65fedf39aefe402d3bb6e24df4d4f5fe4547750' != 'be3563ae3f795b2b4353bcce3a527ad0a4f7f644' (at byte 0)
1: 
1/9 Test #1: offline ..........................***Failed  149.58 sec
[…]

Another assert hits in version 1.4.3 only, if you run the tests as root user:

[…]
1: worktree::worktree...................................
1: 
1:   1) Failure:
1: core::path::validate_current_user_ownership [/home/bebuch/media/tmp/tmp5/libgit2-1.4.3/tests/core/path.c:760]
1:   is_cur != 0
1:   1 != 0
1: 
1:   2) Failure:
1: refs::revparse::date [/home/bebuch/media/tmp/tmp5/libgit2-1.4.3/tests/refs/revparse.c:28]
1:   String mismatch: objstr != expected_oid
1:   'a65fedf39aefe402d3bb6e24df4d4f5fe4547750' != 'be3563ae3f795b2b4353bcce3a527ad0a4f7f644' (at byte 0)
1: 
1/9 Test #1: offline ..........................***Failed  149.58 sec
[…]

Version of libgit2 (release number or SHA1)

• release 1.4.3
• release 1.4.2
• release 1.4.1
• release 1.4.0 (multiple additional unittests fail)
• Not affected: release 1.3.1 (but with other failing unit test)

Operating system(s) tested

• Ubuntu 20.04 x86-64 (native)
• Ubuntu 22.04 x86-64 (via docker)

[ethomson]

Thanks for the report - this was fixed in #6299