Advertise and support side-band-64k when calling receive-pack #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (pkt->type == GIT_PKT_FLUSH) { | ||
| git_pkt_free(pkt); | ||
| /* add_push_report_pkt returns GIT_ITEROVER when it receives a flush */ | ||
| if (GIT_ITEROVER == error) |
There was a problem hiding this comment.
Don't wanna be picky, but these reverse comparisons are kind of eww. :)
|
This looks very clean. I guess that means y'all did a very good job at abstracting the networking code. It's nice to see sideband support implemented in a few diff lines. Congratulations! |
vmg
pushed a commit
that referenced
this pull request
Mar 12, 2013
Advertise and support side-band-64k when calling receive-pack
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
Advertise and support side-band-64k when calling receive-pack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a customer try pushing with libgit2 to Gitblit, a JGit-based Git server. Even though we send up
report-statusin the capabilities line, it does not send back a push report. (The push does succeed and the refs are updated on the remote side.) This leads togit_push_finishfailing with the error messageEarly EOF.It looks like this particular Git server will not send back a push report unless we also advertise support for
side-band-64k. If we do advertise support forside-band-64k, then we get back a push report that is not sidebanded at all. This is also weird. If you advertise support forside-band-64kto a real Git server on receive-pack, then you get the push report in sideband channel 1 (data).This pull request adds support for
side-band-64kto the parser for the receive-pack response (the push report), and we start advertising it. So now we support (as does core git) the server sending us the push report sidebanded (or not). That means you can push to a real Git server, or to this Gitblit server, without any trouble.