-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce git_merge_file for consumers #2140
Conversation
So I think that the second point hits consumers like @mhodgson (in his request over in #2119.) After writing the first point, I think it's not what we actually want, I think we want to take a @vmg you mentioned that you might expect a callback here - since xdiff does all this in memory, I would expect to splat this back in a struct, along with the metadata (the resultant filename and mode, selected from the changed entry). |
Brilliant. You're right, since Xdiff is gonna keep everything in memory, we might as well return it as a single struct. The only thing I'd consider is embedding a |
Aren't you clever. I'll take a whack at that. |
@ethomson called me cleveeeer |
Okay, I'm pretty happy with this and would like another set of eyes. I refactored this a bit and as a result exposed |
I like it. ❤️ |
Dig it. I updated the rugged bindings. Should be good to go once we get this merged. Just need to write a few tests once I can build against this. |
👍 Any chance of us getting custom merge driver support soon? |
@jacquesg That's a good question, and a big topic. Would you mind opening a separate issue? |
Will do. |
So! Any comments or complaints on this one? |
Closed via #2183 |
git-merge-file
like API that allows callers to merge files as they exist on disk (that may or may not exist in a repository)git-merge-file
API that allows callers to reproduce the results of checking out a single conflicted file