Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #4211, this PR enables building with "-Werror". I've taken a different approach here than last time by creating new macros
ENABLE_WARNINGS
/DISABLE_WARNINGS
. When passing "-DENABLE_WERROR" to CMake, theENABLE_WARNINGS
macro is switched over to add "-Werror=" instead of "-W<warning" to our CFLAGS variable.I've switched over Travis to use this new switch by default. I'll probably have to disable this for the old Precise machines as they still have the issue with
curl_easy_opt
warnings, which are out of our scope to fix.