Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stash save bug with fast path index check #4668

Merged
merged 1 commit into from Jun 9, 2018

Commits on Jun 6, 2018

  1. Fix stash save bug with fast path index check

    If the index contains stat data for a modified file, and the file is
    not racily dirty, and there exists an untracked working tree directory
    alphabetically after that file, and there are no other changes to the
    repo, then git_stash_save would fail. It would confuse the untracked
    working tree directory for the modified file, because they have the
    same sha: zero.  The wt directory has a sha of zero because it's a
    directory, and the file would have a zero sha because we wouldn't read
    the file -- we would just know that it doesn't match the index.  To
    fix this confusion, we simply check mode as well as SHA.
    novalis committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    5a7d454 View commit details
    Browse the repository at this point in the history