remote: store the connection data in a private struct #4785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pks-t
requested changes
Aug 30, 2018
tiennou
force-pushed
the
fix/cleanup-remote
branch
from
45b178b
to
c7e3bdd
Compare
pks-t
reviewed
Sep 7, 2018
|
I'm good with this PR despite the one naming issue I have right now. |
This makes it easier to pass connection-related options around (proxy & custom headers for now). This fixes a bug in git_push_finish, which didn't reuse the provided proxy if the connection closed between the call to `git_remote_push` and the finish step.
tiennou
force-pushed
the
fix/cleanup-remote
branch
from
c7e3bdd
to
1c17688
Compare
|
I've updated the naming (good catch) and rebased on top of master. Thanks for the review @pks-t ! |
|
/rebuild |
|
Okay, @pks-t, I started to rebuild this pull request. |
pks-t
approved these changes
Sep 7, 2018
|
Thank you, @tiennou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to pass connection-related options around (proxy & custom headers for now).
This fixes a bug in
git_push_finish, which didn't reuse the provided proxy if the connection closed between the call togit_remote_pushand the finish step.