config_file: properly ignore includes without "path" value #4832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config_file: properly ignore includes without "path" value
In case a configuration includes a key "include.path=" without any
value, the generated configuration entry will have its value set to
NULL
. This is unexpected by the logic handling includes, and as soonas we try to calculate the included path we will unconditionally
dereference that
NULL
pointer and thus segfault.Fix the issue by returning early in both
parse_include
andparse_conditional_include
in case where thefile
argument isNULL
.Add a test to avoid future regression.
The issue has been found by the oss-fuzz project, issue 10810.