Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ninja build #4841

Merged
merged 2 commits into from
Oct 20, 2018
Merged

Ninja build #4841

merged 2 commits into from
Oct 20, 2018

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Oct 8, 2018

A quick attempt at #4838. This also explicitly selects OpenSSL as a backend, just to make sure it doesn't auto-disable it.

@tiennou
Copy link
Contributor Author

tiennou commented Oct 8, 2018

As suspected, the CMake version on 16.04 doesn't support Ninja, as per its confused error. Note that the only green Ubuntu build is because I missed switching it to Ninja in the first place.

It looks like it shaves almost a minute from the macOS build step, which is impressive, but ends up being slower overall (which looks to be caused by "generic network latency difference" between compared builds because of "differing datacenter usage" or something). It looks like grabbing Ninja from Homebrew also adds some delay (±15s when comparing "now" baselines).

Example list of builds :

(Sorry for the notification noise, I was looking for some candidates PR for baselining)

@pks-t
Copy link
Member

pks-t commented Oct 19, 2018

Cool, thanks for giving this a go! So from the results it looks like we might want to enable it for macOS, right? If it saves about a minute for build but requires 15 seconds more for homebrew that should be a net win of about 45 seconds

azure-pipelines.yml Outdated Show resolved Hide resolved
@tiennou
Copy link
Contributor Author

tiennou commented Oct 19, 2018

Fixed and rebased !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants