Move giterr to git_error
#4917
Move giterr to git_error
#4917
Conversation
|
/rebuild |
4 similar comments
|
/rebuild |
|
/rebuild |
|
/rebuild |
|
/rebuild |
|
(Apologies for the spam, I'm debugging the rebuilder) |
|
/rebuild |
1 similar comment
|
/rebuild |
|
Okay, @ethomson, I started to rebuild this pull request as build #1159. |
ethomson
force-pushed
the
ethomson/giterr
branch
from
d8a55eb
to
6709856
Compare
|
Updating to fix some conflicts; I'll likely merge this soonish to unblock us for a release since I'm not hearing any yelling. |
include/git2/errors.h
Outdated
| */ | ||
| /**@{*/ | ||
|
|
||
| #define GITERR_NONE GIT_ERROR_NONE |
There was a problem hiding this comment.
An alternative would be to use const int, which would allow to mark those as GIT_DEPRECATED.
Last time I checked, compiler support for deprecating macros wasn't standardized.
ethomson
force-pushed
the
ethomson/giterr
branch
4 times, most recently
from
6612b8b
to
e429fd6
Compare
|
That's a lot of changes :) But I'm all for it, so thanks for doing it. |
Move to the `git_error` name in error-related functions, deprecating the `giterr` functions. This means, for example, that `giterr_last` is now `git_error_last`. The old names are retained for compatibility. This only updates the public API; internal API and function usage remains unchanged.
Replace the `GITERR` values with a `const int` to deprecate error values.
Move to the `git_error` name in the internal API for error-related functions.
Update GITERR and giterr usages in the static code analysis tools to use the new names.
ethomson
force-pushed
the
ethomson/giterr
branch
from
e429fd6
to
a27a4de
Compare
|
Rebased onto master, since this touched so many places, there were a great many conflicts. And surely, upon merging this, I will unleash a great many more conflicts to the world. Sorry everyone. |
Much like #4807, refactor
giterrfunctions and enums to match more closely with our naming conventions. This moves thegiterr_functions togit_error_, while providing proxies with the old, now-deprecated names, for backward compatibility. Similarly, this moves theGITERR_enums toGIT_ERROR_(while again providing backcompat).