Fix a memory leak in odb_otype_fast() #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found an uncovered codepath while hunting for an unrelated memory leak. Unfortunately the test only makes sense if #3918 is merged and ASan is enabled (meaning that the fix can be missing and it would still pass!). |
pks-t
reviewed
Feb 20, 2019
| @@ -1124,6 +1124,7 @@ static int odb_otype_fast(git_object_t *type_p, git_odb *db, const git_oid *id) | |||
|
|
|||
| if ((object = git_cache_get_raw(odb_cache(db), id)) != NULL) { | |||
| *type_p = object->cached.type; | |||
| git_odb_object_free(object); | |||
There was a problem hiding this comment.
Yup. git_cache_get_raw calls cache_get, which in turn calls git_cached_obj_incref on the returned entry. So it's the right thing to free the object here.
This change frees a copy of a cached object in odb_otype_fast().
lhchavez
force-pushed
the
fix-odb_otype_fast-leak
branch
from
bda2b96
to
6b3730d
Compare
|
Thanks a lot, @lhchavez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change frees a copy of a cached object in odb_otype_fast().