Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip UTF8 BOM in ignore files #5075

Merged
merged 2 commits into from
May 21, 2019
Merged

Skip UTF8 BOM in ignore files #5075

merged 2 commits into from
May 21, 2019

Conversation

ethomson
Copy link
Member

When parsing an ignore or attribute file, we should skip a UTF8 BOM.

Fixes #5071

@ethomson
ignore: test we can handle an ignore file with BOM
73a157e 
Ensure that we can read and parse an ignore file with a UTF8 BOM.
@ethomson
ignore: skip UTF8 BOM in ignore file
133bceb
pks-t
pks-t approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@pks-t pks-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@pks-t pks-t merged commit 4aa36ff into master May 21, 2019
@ethomson ethomson deleted the ethomson/ignore_skip_bom branch February 2, 2020 13:08
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pks-t pks-t pks-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.gitignore parsing: BOM not skipped
2 participants
@ethomson @pks-t