Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change API instances of fromnoun to from_noun (with an underscore) #5117

Merged
merged 4 commits into from
Jun 16, 2019
Merged

Change API instances of fromnoun to from_noun (with an underscore) #5117

merged 4 commits into from
Jun 16, 2019

Commits on Jun 15, 2019

  1. oid: is_zero instead of iszero 

    The only function that is named `issomething` (without underscore) was
`git_oid_iszero`.  Rename it to `git_oid_is_zero` for consistency with
the rest of the library.
    @ethomson
    ethomson committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    5d92e54 View commit details
    Browse the repository at this point in the history

  2. blob: add underscore to from functions 

    The majority of functions are named `from_something` (with an
underscore) instead of `fromsomething`.  Update the blob functions for
consistency with the rest of the library.
    @ethomson
    ethomson committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    08f3920 View commit details
    Browse the repository at this point in the history

  3. index: rename frombuffer to from_buffer 

    The majority of functions are named `from_something` (with an
underscore) instead of `fromsomething`.  Update the index functions for
consistency with the rest of the library.
    @ethomson
    ethomson committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    6574cd0 View commit details
    Browse the repository at this point in the history

  4. tag: add underscore to from function 

    The majority of functions are named `from_something` (with an
underscore) instead of `fromsomething`.  Update the tag function for
consistency with the rest of the library.
    @ethomson
    ethomson committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    e45350f View commit details
    Browse the repository at this point in the history