Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake pkg-config modulification #5206

Merged
merged 2 commits into from Sep 19, 2019
Merged

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Aug 17, 2019

This is the CMake module I wrote for mbedTLS, which tries to streamline writing pkg-config files, in an attempt to fix #5203.

This is incomplete (I think), but I'll need guidance, because macOS usually doesn't really care about *.pc files anyways.

Here's a gist of the current changes introduced, at least on macOS. I do think the Libs.private looks "saner", but the Requires.private isn't there yet.

Copy link
Member

@pks-t pks-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this quite a lot. As you said, Requires.private is still missing, but apart from that it already looks quite nice to me. Does this also handle paths with spaces correctly, e.g. for the prefix or linker flags?

cmake/Modules/PkgBuildConfig.cmake Show resolved Hide resolved
@tiennou
Copy link
Contributor Author

tiennou commented Sep 14, 2019

Okay, I've added some quoting in the hope that would be sufficient 😉. I've updated the gist with an OpenSSL, non-PCRE run, as a syntax check.

@pks-t pks-t merged commit aa407ca into libgit2:master Sep 19, 2019
@pks-t
Copy link
Member

pks-t commented Sep 19, 2019

Tried it on my own system and everything looked good to me. Thanks a lot, @tiennou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCRE dependency information is not stored in libgit2.pc
2 participants