Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valgrind: suppress memory leaks in libssh2_session_handshake #5240

Merged
merged 1 commit into from Sep 21, 2019

Conversation

pks-t
Copy link
Member

@pks-t pks-t commented Sep 21, 2019

On Ubuntu, the combination of libgcrypt and libssh2 is quite old and
known to contain memory leaks. We thus have several functions listed in
our suppressions file that are known to leak. Due to a recent update of
libssh2 or libgcrypt, there now is a new memory leak caused by
libssh2_session_handshake that causes the CI to fail.

Add a new suppression to fix the issue.

@pks-t pks-t force-pushed the pks/valgrind-suppress-gcrypt branch from 7919184 to 655851b Compare September 21, 2019 15:57
@pks-t pks-t changed the title valgrind: correctly suppress leaks in libgcrypt functions valgrind: suppress memory leaks in libssh2_session_handshake Sep 21, 2019
@pks-t
Copy link
Member Author

pks-t commented Sep 21, 2019

Another point in case to provide a libssh backend 🙄

@pks-t pks-t mentioned this pull request Sep 21, 2019
On Ubuntu, the combination of libgcrypt and libssh2 is quite old and
known to contain memory leaks. We thus have several functions listed in
our suppressions file that are known to leak. Due to a recent update of
libssh2 or libgcrypt, there now are new memory leaks caused by
libssh2_session_handshake and libssh2_init that cause the CI to fail.

Add a new suppression to fix the issue.
@pks-t pks-t force-pushed the pks/valgrind-suppress-gcrypt branch from 655851b to 56d5b44 Compare September 21, 2019 16:22
@pks-t pks-t merged commit 9cd5240 into libgit2:master Sep 21, 2019
@pks-t pks-t deleted the pks/valgrind-suppress-gcrypt branch September 21, 2019 17:13
@pks-t
Copy link
Member Author

pks-t commented Sep 21, 2019

I'm fast forwarding this to unbreak CI

@ethomson
Copy link
Member

I'm fast forwarding this to unbreak CI

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants