Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error return for invalid extensions. #5656

Merged
merged 1 commit into from Oct 8, 2020
Merged

Fix error return for invalid extensions. #5656

merged 1 commit into from Oct 8, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 7, 2020

git_repository_open_ext and repo_init_config were returning 1 instead of -1 when there is an unsupported extension in the config.

@ehuss ehuss mentioned this pull request Oct 7, 2020
Closed
@ethomson
Copy link
Member

ethomson commented Oct 8, 2020

Oof. Good catch, thanks for the fix.

@ethomson ethomson merged commit 2307a22 into libgit2:master Oct 8, 2020
@chachi chachi mentioned this pull request Oct 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson ethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehuss @ethomson