ntmlclient: fix linking with libressl #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jan 6, 2022
Patch upstream: libgit2/libgit2#6157 PR: 260216 Reported by: lysfjord.daniel@smokepit.net
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jan 6, 2022
Patch upstream: libgit2/libgit2#6157 PR: 260216 Reported by: lysfjord.daniel@smokepit.net (cherry picked from commit 7679b30)
|
The ifdef will become a bit unwieldy: Perhaps it would make more sense to test from cmake whether the OpenSSL lib provides |
Indeed that would be a better alternative:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a PR from the patch provided by @Nuadh in #6134
libressl still declares HMAC_CTX_cleanup so we can't create the dummy function in that case.