midx: fix large offset table check. #6309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2022 14:00
It's insufficient to only check if the offset high order bit is set, we must also check to see if object_large_offsets are in use. This bug is causing objects to appear missing because they can't be found in the index.
Though both are correct, this makes it clear that we're dealing with the same value.
ccstolley
force-pushed
the
ccs_fix_midx_offset
branch
from
8ab09e3
to
97954ee
Compare
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's insufficient to only check if the offset high order bit is set, as some object offsets may have their high order bit set but still not use the large offsets table.
We must also check to see if object_large_offsets are in use.
This can cause libgit2 to falsely claim objects do not exist when they actually do, because it is unable to find the object in the index.
cc: @lhchavez as the original author of MIDX support.