push: set generic error in push_negotiation cb #6675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user returns `-1` in a `push_negotiation` callback, we set the error to whatever's hanging out in the buffer, probably something about a missing configuration entry. Clear the error buffer before invoking the callback, so that if a user does not set an error message in their callback that we can detect. If there is no error but `-1` is returned, set a generic error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user returns
-1in apush_negotiationcallback, we set the error to whatever's hanging out in the buffer, probably something about a missing configuration entry.Clear the error buffer before invoking the callback, so that if a user does not set an error message in their callback that we can detect. If there is no error but
-1is returned, set a generic error message.Fixes #6672