Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #6747

Merged
merged 2 commits into from Mar 8, 2024
Merged

Fix broken links #6747

merged 2 commits into from Mar 8, 2024

Conversation

csware
Copy link
Contributor

@csware csware commented Feb 24, 2024

fixes #6570

Signed-off-by: Sven Strickroth <email@cs-ware.de>
@csware
Copy link
Contributor Author

csware commented Feb 24, 2024

The tests are flaky. There is no code change!

@ethomson
Copy link
Member

Why did libgit2.github.com break without any warning? I know that we were special cased or something to keep that domain but that's very annoying. @carlosmn any way you can find out what happened?

@ethomson
Copy link
Member

It looks like all these links work again?

@csware
Copy link
Contributor Author

csware commented Mar 1, 2024

No.

@ethomson
Copy link
Member

ethomson commented Mar 1, 2024

Oh, I see, it's not preserving the path in the redirect. That's probably my fault from when I moved off Google Domains.

@ethomson
Copy link
Member

ethomson commented Mar 1, 2024

Nope, it's GitHub, not including the path in our redirects. 🙃

Can we update the links to libgit2.org instead of github.io?

Signed-off-by: Sven Strickroth <email@cs-ware.de>
@csware
Copy link
Contributor Author

csware commented Mar 1, 2024

Done.

@ethomson
Copy link
Member

ethomson commented Mar 8, 2024

Thanks!

@ethomson ethomson merged commit 8fc7798 into libgit2:main Mar 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs in example code are broken
2 participants