Turn CommitCollection into a IQueryable<Commit>

[nulltoken]

No description provided.

[nufyoot]

For the IQueryable<Commit> do you have a design pattern we should use? If building around the Commit object then what would be the best way to allow filtering by branch, reference, tag or tag annotation?

[nufyoot]

To elaborate a little more, would you recommend creating something like this:

LibGit2Sharp.Repository repo;
LibGit2Sharp.Branch branch;

repo.Commits.Where(c => branch.Commits.Contains(c));

[nulltoken]

@nufyoot

If building around the Commit object then what would be the best way to allow filtering by branch, reference, tag or tag annotation?

I may not completely understand your whole question. For instance, I'm not sure to clearly get what would filtering by a tag return.

For the IQueryable do you have a design pattern we should use?

What would be the alternatives?

/cc @davidfowl, @aroben

[nufyoot]

I'm not sure about alternatives for the IQueryable usage. As for filtering by tag, I merely just read the documentation for the QueryBy function.

[nulltoken]

As for filtering by tag, I merely just read the documentation for the QueryBy function.

OMG... Ok I got it. I clearly misunderstood your remark!

Below my first thoughts:

The QueryBy method defines "boundaries" the revwalk should honor (For instance: start at the commits pointed at by this this branch and this tag and enumerate all their parents until you reach this commit (or until your reach a commit with no parent))

Currently, repo.Commits is a shortcut for repo.Commits.QueryBy( new Filter { Since = repo.Head } );

When I looked at the code repo.Commits.Where(c => branch.Commits.Contains(c)); here's what I understood "Enumerate all the commits that are reachable from both the HEAD and this other branch."

repo.Commits.QueryBy( new Filter { Since = new object[] { repo.Head, branch } } ); would rather mean "Enumerate all the commits that are reachable from either the HEAD or and this other branch.".

[nufyoot]

Ah, good point. What would be a comfortable syntax do you think? Perhaps add either a method to Commit or an extension method that could be used outside the IQueryable implementation, but is built primarily for IQueryable?

Perhaps something like:

LibGit2Sharp.Repository repo;
LibGit2Sharp.Branch branch1;
LibGit2Sharp.Branch branch2;

repo.Commits.Where(c => c.IsAfter(branch) && c.IsBefore(branch));

Or maybe something like that? I'm up for any suggestions.

[nulltoken]

@nufyoot

What would be a comfortable syntax do you think?

I've thought about this, and I can't come up with something that would be both intuitive and discoverable.

I'm starting to wonder if trying to get rid of QueryBy is achievable, while still making it "easy" for the consumer to process and filter the commits.

The retrieval of the commits through the CommitCollection is already deferred thanks to the CommitEnumerator. Is there another advantage to IQueryable<> that I'm missing?

[nulltoken]

Closing this for now. Feel free to reopen if needed