Tags are recognized as commits

[gorbach]

Hi! I've found a strange issue. Enumerating tag in repository git://github.com/spdr870/gitextensions.git gives 81 nulls and 1 real tag. All other tags are visible in repo.Refs as commits.

Code to list tags:

        const string path = @"x:/git/ge/.git";
        using (var repo = new Repository(path))
        {
            int found = 0;
            foreach (var tag in repo.Tags.Where(t => t != null))
            {
                Console.WriteLine(tag.Name);
                found++;
            }

            Console.WriteLine("Found {0} of {1} tags.",found, repo.Tags.Count());

        }

sample code is available here - git@github.com:gorbach/libgit2sharp.git (branch git-log)

[tclem]

Hmm... That is strange. I'll take a look!

[tclem]

Ok. So we aren't quite handling tag listing properly right now. I need to actually lookup the tag using the reference instead of just looking at what that reference points too (which is obviously a commit in most cases). It also looks like tag listing is actually getting support in libgit2 soon based on this PR.

[nulltoken]

I think I nailed the root cause.

Git handles two different kinds of tags (annotated and lightweight).

• Lightweight tags are nothing more than a direct reference to an object (commit, tree, ...)
• Annotated tags are a combination of a tag-object stored in the git object database and a direct reference to this tag-object

@gorbach :

Currently, the "null" tags that you encounter are Lightweight tags.
Thanks for spotting this. It's a very nice issue :) We're working on it! Fixing this will require some slights changes to the API.

[gorbach]

Yes, you right. This issue is caused by lightweight tags.

[nulltoken]

We've added support for lightweight tags.

Would you please check that nulltoken/libgit2sharp@1b73c29 indeed fixes the issue?

[gorbach]

Thanks! Merged your fix, works very well. Waiting for merge in main branch.

[nulltoken]

Quite glad it works as expected :)

Should be merged by tomorrow.

[nulltoken]

This fix has been merged to libgit2/master. Thanks for having pointed this issue out :)