New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce GlobalSettings.Version #726
Comments
Is the CPU arch of libgit2(sharp) going to be different than the one you can get from the runtime? |
On that topic, is the version number that's baked in going to be different from the version stamped into the DLL itself? |
I was thinking Would you think of a better name? |
@ethomson: It will be retrieved through Assembly assembly = typeof(Repository).Assembly;
Version version = assembly.GetName().Version; |
Why do we have CpuArchitecture as a string? Shouldn't we simply do Environment.Is64BitProcess? http://msdn.microsoft.com/en-us/library/system.environment.is64bitprocess(v=vs.110).aspx |
@Therzok You're right. That may make no sense to actually expose this property, provided the x86|amd64 is rendered through the |
Also, why would the Version return BuiltInFeatures? |
BuildInFeatures is already a member of GlobalSettings. |
GlobalSettings.Features() would be deprecated in favor of GlobalSettings.Version.BuiltInFeatures |
Fixed in vNext |
Once #717 is merged, how about introducing
GlobalSettings.Version
?This would be a type exposing several properties
The
ToString()
method would be overriden to produce whatRepository.Version
outputs nowadays.Repository.Version
would be deprecated in favor of this new type.Thoughts?
The text was updated successfully, but these errors were encountered: