Trying to fetch all tags fails

[nulltoken]

Related to this: http://stackoverflow.com/questions/28091482/how-to-pull-all-new-tags-using-libgit2sharp

Essentially I would like to use libgit2sharp to achieve 'git pull --tags'
I am using libgit2sharp 0.20.2

Here is a sample which fails for me:

static void Main(string[] args)
{
    const string haskellMode = "https://github.com/haskell/haskell-mode.git";

    var guid = Guid.NewGuid().ToString();
    var wdir = string.Format("%TEMP%/git-fetch-tags-{0}", guid);
    wdir = Environment.ExpandEnvironmentVariables(wdir);

    var sig = new Signature("hendrik", "hendrik@somemail.ee", new DateTimeOffset());

    var repoWithTags = Repository.Clone(haskellMode, wdir);
    Console.WriteLine(repoWithTags);

    using (var repo = new Repository(repoWithTags))
    {
        // this one works, but if there are any new tags in the remote it does not get them
        repo.Network.Pull(sig, new PullOptions());

        // this one throws
        repo.Network.Pull(sig, new PullOptions { FetchOptions = new FetchOptions { TagFetchMode = TagFetchMode.All } });

        // this one also throws but I think it manages to get the tags
        repo.Fetch("origin", new FetchOptions { TagFetchMode = TagFetchMode.All });

        Console.WriteLine("Done for {0}", haskellMode);
    }

    Console.ReadLine();
}

[nulltoken]

@hendrikmaarand Thanks a lot for raising this! Just a quick request:

Could you please also add the complete exception stack traces regarding the failures?

[hendrikmaarand]

Stack trace for the first one:

LibGit2Sharp.LibGit2SharpException: ref 'refs/remotes/origin/master' doesn't match the destination
  at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
  at LibGit2Sharp.Core.Ensure.ZeroResult(Int32 result)
  at LibGit2Sharp.Core.Proxy.git_remote_fetch(RemoteSafeHandle remote, Signature signature, String logMessage)
  at LibGit2Sharp.Network.DoFetch(RemoteSafeHandle remoteHandle, FetchOptions options, Signature signature, String logMessage)
  at LibGit2Sharp.Network.Fetch(Remote remote, FetchOptions options, Signaturesignature, String logMessage)
  at LibGit2Sharp.Network.Pull(Signature merger, PullOptions options)   
  at ConsoleApplication4.Program.Main(String[] args) in c:\Users\hendrik\Documents\Visual Studio 2013\Projects\ConsoleApplication4\ConsoleApplication4\Program.cs:line 30

For the second one:

LibGit2Sharp.LibGit2SharpException: ref 'refs/remotes/origin/master' doesn't match the destination
  at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
  at LibGit2Sharp.Core.Ensure.ZeroResult(Int32 result)
  at LibGit2Sharp.Core.Proxy.git_remote_fetch(RemoteSafeHandle remote, Signature signature, String logMessage)
  at LibGit2Sharp.Network.DoFetch(RemoteSafeHandle remoteHandle, FetchOptions options, Signature signature, String logMessage)
  at LibGit2Sharp.Network.Fetch(Remote remote, FetchOptions options, Signature signature, String logMessage)
  at LibGit2Sharp.RepositoryExtensions.Fetch(IRepository repository, String remoteName, FetchOptions options)
  at ConsoleApplication4.Program.Main(String[] args) in c:\Users\hendrik\Documents\Visual Studio 2013\Projects\ConsoleApplication4\ConsoleApplication4\Program.cs:line 34

[nulltoken]

@hendrikmaarand Great! Could you please also include the exception messages?

[hendrikmaarand]

@nulltoken Updated!

[nulltoken]

Hmmm. I can't repro against the latest vNext. The following test pass

[Fact]
public void Issue_927()
{
    var scd = BuildSelfCleaningDirectory();

    string clonedRepoPath = Repository.Clone("https://github.com/haskell/haskell-mode.git", scd.DirectoryPath);

    using (var repo = new Repository(clonedRepoPath))
    {
        var sig = new Signature("hendrik", "hendrik@somemail.ee", new DateTimeOffset());
        repo.Network.Pull(sig, new PullOptions());
        repo.Network.Pull(sig,
            new PullOptions { FetchOptions = new FetchOptions { TagFetchMode = TagFetchMode.All } });
        repo.Fetch("origin", new FetchOptions { TagFetchMode = TagFetchMode.All });
    }
}

Can you confirm?

If you're not willing to build the source code by yourself, you could download a prerelase NuGet package from https://ci.appveyor.com/project/libgit2/libgit2sharp/build/0.20.2.127/job/b74exootjw18apt2/artifacts and check your code against this new version (this will require you to add a new local NuGet source).

Please, do not use this package in production 😉

[nulltoken]

Confirmed repro in v0.20.2

[nulltoken]

Thanks a lot for this report... and sorry for the inconvenience 😕

Will be fixed as part of v0.21 (which should be released shortly).

[nulltoken]

@carlosmn git fetch against a newly initialized repository with the following config

[core]
    repositoryformatversion = 0
    filemode = false
    bare = false
    logallrefupdates = true
    symlinks = false
    ignorecase = true
    hideDotFiles = dotGitOnly
[remote "origin"]
    url = https://github.com/libgit2/TestGitRepository
    fetch = +refs/heads/*:refs/remotes/origin/*

outputs

$ git fetch
remote: Counting objects: 68, done.
remote: Total 68 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (68/68), done.
From https://github.com/libgit2/TestGitRepository
 * [new branch]      first-merge -> origin/first-merge
 * [new branch]      master     -> origin/master
 * [new branch]      no-parent  -> origin/no-parent
remote: Counting objects: 1, done.
remote: Total 1 (delta 0), reused 1 (delta 0)
Unpacking objects: 100% (1/1), done.
 * [new tag]         annotated_tag -> annotated_tag
 * [new tag]         blob       -> blob
 * [new tag]         commit_tree -> commit_tree

Aren't we missing something in the way we handle the auto mode?

[carlosmn]

git is noticing that the server did not automatically send the tags and is performing a second fetch. This second fetch is completely different from the first one, so atm I don't think libgit2 should emulate that behaviour since we implement the underlying functionality, not the UI git wants to provide.

[nulltoken]

@carlosmn Thanks for this explanation. Do you think LibGit2Sharp should mimic git behavior?

/cc @ethomson @jamill @dahlbyk @Therzok

[jamill]

I think so - or at least a way to have it fetch with "expected" behavior. If someone wanted the "underlying functionality" behavior, maybe we could expose that as an advanced method.

As a writer of an application calling into lg2#'s fetch, I would expect for it to fetch tags (and not have to handle that in my application).

[nulltoken]

Created #936 to keep track of this.

[nulltoken]

@hendrikmaarand I've transmuted this issue into a Pull Request with additional test coverage.