Fix issue with old libgit2 API calls causing the PHP extension to not load on compilation #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error for the php module
|
I'm sorry for late response. i'll check this later. |
|
Hello, Just tested this change. It solved the problem for me. |
chobie
added a commit
that referenced
this pull request
Nov 7, 2013
Fix issue with old libgit2 API calls causing the PHP extension to not load on compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon attempting to compile and utilise the PHP module, we were getting repeated:
Errors on Apache restart, seems the index.c file for the extension was attempting to utilise API calls that have been renamed in the libgit2 library.
This change fixes this and loads the extension, and through our usage scenarios so far works as intended.
This commit fixes issues #44 and #28