Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported library to libgit 0.19 #53

Merged
merged 2 commits into from
Jan 8, 2014

Conversation

christopherobin
Copy link
Contributor

Just some quick changes and all tests pass without issues.
If necessary I could probably publish and maintain the package on PECL.

@opensaurusrex
Copy link

I think they let it die. Sad because I could have used it.

chobie added a commit that referenced this pull request Jan 8, 2014
@chobie chobie merged commit 6cf41b0 into libgit2:develop Jan 8, 2014
@chobie
Copy link
Member

chobie commented Jan 8, 2014

I'm sorry about missing this PR. I was very busy on that days.

we consider throw away OOP interface before propose PECL as It tough to follow latest changes.

@christopherobin
Copy link
Contributor Author

Yeah, switching to functions would probably make things a lot easier, and users could just fallback to the official API documentation for what to expect from each function call.

I don't mind having a go at it when I have some time later.

@opensaurusrex
Copy link

I would prefer the option for OOP interfaces, because I would like to be able to extend them, if I need to. Also passing Objects is much easier than having to use functions. Feel free to offer functions but like PHP does with a lot of extensions offer the interfaces as well.

@chobie
Copy link
Member

chobie commented Jan 8, 2014

Have you read http://libgit2.github.com/libgit2/#HEAD ?

If we provide right OOP interface continuously, we will stop development as considering right interfaces (especially, Keeping compatibilities) are very tough task in this large scale library.

Almost people can't do full-time work for OSS library. So switching to functions is better choice. Then we could easy to follow latest API, maintain it and accept PRs.

Unfortunately, keeping OOP classes are very low priority.

Then, why current php-git provides classes? Because libgit2 was small library at that time.

@opensaurusrex
Copy link

Well, with that in mind I guess I can understand it. Too bad we didn't have more people who know extension coding who were interesting in helping out. I myself am looking into it now to see if I can be of some help to it.

@christopherobin
Copy link
Contributor Author

What could be done is that while the extension switches to procedural functions, the OOP wrapper can be written as a separate PHP library that can then be maintained by the users without having them deal with the C internals of PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants