Do not access freed memory in test_push_options()

Fixes #1301
libgit2 · Jun 10, 2024 · 5b27dee · 5b27dee
1 parent a9c7cce
commit 5b27dee
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/test/test_remote.py b/test/test_remote.py
@@ -373,10 +373,9 @@ def test_push_options(mock_callbacks, origin, clone, remote):
     remote.push(['refs/heads/master'], push_options=['foo'])
     remote_push_options = mock_callbacks.return_value.push_options.remote_push_options
     assert remote_push_options.count == 1
-    assert ffi.string(remote_push_options.strings[0]) == b'foo'
+    # strings pointed to by remote_push_options.strings[] are already freed
 
     remote.push(['refs/heads/master'], push_options=['Option A', 'Option B'])
     remote_push_options = mock_callbacks.return_value.push_options.remote_push_options
     assert remote_push_options.count == 2
-    assert ffi.string(remote_push_options.strings[0]) == b'Option A'
-    assert ffi.string(remote_push_options.strings[1]) == b'Option B'
+    # strings pointed to by remote_push_options.strings[] are already freed