-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS wheels don't work on macOS 10.12 #1026
Comments
ping @rcoup |
Add some tracing of libgit2 dependencies. re libgit2#1026
@RazerM I'm a little out of my depth here, but can you have a quick try of the wheels produced from 2833dc1? And can you run some diagnostics under macos10.9 for me? $ otool -L /path/to/pygit2/_pygit2.cpython-37m-darwin.so
$ otool -l /path/to/pygit2/_pygit2.cpython-37m-darwin.so | grep -A4 VER
$ otool -L /path/to/pygit2/.dylibs/libgit2.1.0.0.dylib
$ otool -l /path/to/pygit2/.dylibs/libgit2.1.0.0.dylib | grep -A4 VER |
The wheel you linked to works! I assume you want the diagnostics from the pygit2 I compiled from source (?):
|
That seems suspiciously easy... 🕵️ There are some warnings during the libgit2 compilation:
Seems like Libgit2 cmake actually checks for it explicitly:
though https://gitlab.kitware.com/cmake/cmake/-/issues/17101#note_297983 suggests the CheckFunctionExists test in cmake doesn't actually respect macOS deployment targets. @jdavid happy to commit this change anyway? |
Includes a build fix for the updated libgit2 1.1.x, figured it may as well be updated at the same time. 1.3.0 (2020-09-18) ------------------------- - New ``Repository.add_submodule(...)`` `#1011 <https://github.com/libgit2/pygit2/pull/1011>`_ - New ``Repository.applies(...)`` `#1019 <https://github.com/libgit2/pygit2/pull/1019>`_ - New ``Repository.revparse(...)`` and ``Repository.revparse_ext(...)`` `#1022 <https://github.com/libgit2/pygit2/pull/1022>`_ - New optional ``flags`` and ``file_flags`` arguments in ``Repository.merge_commits`` and ``Repository.merge_trees`` `#1008 <https://github.com/libgit2/pygit2/pull/1008>`_ - New ``Reference.raw_target``, ``Repository.raw_listall_branches(...)`` and ``Repository.raw_listall_references()``; allow bytes in ``Repository.lookup_branch(...)`` and ``Repository.diff(...)`` `#1029 <https://github.com/libgit2/pygit2/pull/1029>`_ - New ``GIT_BLAME_FIRST_PARENT`` and ``GIT_BLAME_USE_MAILMAP`` constants `#1031 <https://github.com/libgit2/pygit2/pull/1031>`_ - New ``IndexEntry`` supports ``repr()``, ``str()``, ``==`` and ``!=`` `#1009 <https://github.com/libgit2/pygit2/pull/1009>`_ - New ``Object`` supports ``repr()`` `#1022 <https://github.com/libgit2/pygit2/pull/1022>`_ - New accept tuples of strings (not only lists) in a number of places `#1025 <https://github.com/libgit2/pygit2/pull/1025>`_ - Fix compatibility with old macOS 10.9 `#1026 <https://github.com/libgit2/pygit2/issues/1026>`_ `#1027 <https://github.com/libgit2/pygit2/pull/1027>`_ - Fix check argument type in ``Repository.apply(...)`` `#1033 <https://github.com/libgit2/pygit2/issues/1033>`_ - Fix raise exception if error in ``Repository.listall_submodules()`` commit 32133974 - Fix a couple of refcount errors in ``OdbBackend.refresh()`` and ``Worktree_is_prunable`` commit fed0c19c - Unit tests `#800 <https://github.com/libgit2/pygit2/issues/800>`_ `#1015 <https://github.com/libgit2/pygit2/pull/1015>`_ - Documentation `#705 <https://github.com/libgit2/pygit2/pull/705>`_
The wheels report 10.9+ compatibility but don't work on 10.12. The same error happens for the 1.2.0 and 1.2.1 wheels:
I guess they use a symbol from a newer libSystem.
(I know the workaround is to do
pip install --no-binary pygit2 pygit2
).In case it's related, see pyca/cryptography#5215 and pyca/infra#275
The text was updated successfully, but these errors were encountered: