Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress callback support #274

Closed
rmccue opened this issue Oct 27, 2013 · 1 comment · Fixed by #324
Closed

Add progress callback support #274

rmccue opened this issue Oct 27, 2013 · 1 comment · Fixed by #324

Comments

@rmccue
Copy link

rmccue commented Oct 27, 2013

The underlying functions in libgit2 support progress callbacks, but this isn't exposed via pygit2.

I'd be happy to have a go at patching this; is there any forseeable issue with passing Python callbacks in directly, or do we need a layer of indirection in the pygit2 layer?

@jdavid
Copy link
Member

jdavid commented Oct 29, 2013

There must be an indirection, the function signatures are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants