Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: enumerating pygit2.Tree with submodules raises KeyError #967

Closed
ddevault opened this issue Jan 2, 2020 · 3 comments
Closed

Regression: enumerating pygit2.Tree with submodules raises KeyError #967

ddevault opened this issue Jan 2, 2020 · 3 comments
Labels
bug

Comments

@ddevault
Copy link
Contributor

ddevault commented Jan 2, 2020 

$ git clone https://git.sr.ht/~sircmpwn/drewdevault.com
$ cd drewdevault.com
$ python3
>>> from pygit2 import Repository
>>> repo = Repository(".")
>>> c = repo.get(repo.head.target)
>>> list(c.tree)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
KeyError: 'object not found - no match for id (a677dcf495c1973ba11a74d65676a003224d44c4)'
@ddevault
Copy link
Contributor Author

ddevault commented Jan 2, 2020

@jdavid I'm fairly certain this was introduced by your TreeEntry refactorings, can you take a look?

@jdavid jdavid added the bug label Jan 4, 2020
@jdavid jdavid closed this as completed in 2ebfeb8 Jan 5, 2020
@ddevault
Copy link
Contributor Author

ddevault commented Jan 5, 2020 via email

jdavid added a commit that referenced this issue Jan 11, 2020
@jdavid
Lazy load objects from tree entries, fixes #967
b0c19d7
@jdavid
Copy link
Member

jdavid commented Jan 11, 2020

Just released 1.0.2 with the fix

@jdavid jdavid mentioned this issue Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdavid @ddevault