fix windows VC9 build #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move variable declarations to the top of the functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I'm experimenting with libgit2/pygit2 on Windows, using Visual Studio 9 2008 (i.e. VC9).
The first obstacle was a few compilation errors which could be easily fixed.
This corresponds to the present pull request.
The second thing was a linking error, but it was rather due to the way libgit2 was built, and with the following libgit2 change, pygit2 links fine.
The last thing I noticed were a few problems during the tests. One is known (#60), the others are crashes in
test_repository.py(test_new_repoandtest_write, both involve arepo.writeoperation). I'm currently investigating, if I find something I'll propose another fix.