Remove decrement of reference when using Py_None #1161 #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! |
|
Wonderful I will try to follow up tonight! |
|
Addressed! Let me know if you need me to squash the commits or to fix the history somehow! |
|
Yes please, squash the commits. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1161
If the representation of a signature requires the use of
Py_Nonewe should not decrement the reference count of the specialPy_Noneobject.I tried adding a unit test to verify this new behavior, unfortunately, all the unit test I could come up with were not triggering the bug.
This was tested against the reproduce example in the issue setting the env var PYTHONPATH.