Release GIL in Walker.__next__ #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first call to git_revwalk_next may take a while to complete in large repositories -- sometimes a couple of seconds. Release the GIL during git_revwalk_next to avoid locking up multithreaded applications. (Note: cffi wraps C function calls in a similar fashion.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first call to
git_revwalk_nextmay take a while to complete in large repositories – sometimes a couple of seconds.This PR releases the Global Interpreter Lock (GIL) during
git_revwalk_nextto avoid locking up multithreaded applications. (Note: cffi wraps C function calls in a similar fashion.)A possible use case for this is to keep a GUI application responsive while a background thread is iterating on a Walker. Before this change, pygit2 would hold onto the GIL while calling into git_revwalk_next, causing the UI thread to freeze.